Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

refactor tests #2853

Merged

Conversation

BalduinLandolt
Copy link
Contributor

Pull Request Checklist

Task Description/Number

Issue Number: DEV-

Basic Requirements

Please check if your PR fulfills the following requirements:

  • Tests for the changes have been added (for bug fixes / features)
  • Docs have been added / updated (for bug fixes / features)

PR Type

What kind of change does this PR introduce?

  • fix: represents bug fixes
  • refactor: represents production code refactoring
  • feat: represents a new feature
  • docs: documentation changes (no production code change)
  • chore: maintenance tasks (no production code change)
  • test: all about tests: adding, refactoring tests (no production code change)
  • other... Please describe:

Does this PR introduce a breaking change?

  • Yes
  • No
  • Maybe (not 100% sure => check with FE)

Does this PR change client-test-data?

  • Yes (don't forget to update the JS-LIB team about the change)
  • No

@BalduinLandolt BalduinLandolt self-assigned this Sep 25, 2023
@codecov
Copy link

codecov bot commented Sep 25, 2023

Codecov Report

All modified lines are covered by tests ✅

Comparison is base (3cbb8d4) 21.96% compared to head (7fa62a2) 21.95%.

Additional details and impacted files
@@                        Coverage Diff                         @@
##           textvalues/remove-old-messages    #2853      +/-   ##
==================================================================
- Coverage                           21.96%   21.95%   -0.01%     
==================================================================
  Files                                 244      244              
  Lines                               23970    23970              
==================================================================
- Hits                                 5264     5263       -1     
- Misses                              18706    18707       +1     

see 1 file with indirect coverage changes

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@BalduinLandolt BalduinLandolt marked this pull request as ready for review October 4, 2023 08:00
@BalduinLandolt BalduinLandolt merged commit 9e35887 into textvalues/remove-old-messages Oct 4, 2023
9 of 13 checks passed
@BalduinLandolt BalduinLandolt deleted the textvalues/refactor-tests branch October 4, 2023 08:00
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant