Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

apply new model to test data #2780

Conversation

BalduinLandolt
Copy link
Contributor

Pull Request Checklist

Task Description/Number

Issue Number: DEV-

Basic Requirements

Please check if your PR fulfills the following requirements:

  • Tests for the changes have been added (for bug fixes / features)
  • Docs have been added / updated (for bug fixes / features)

PR Type

What kind of change does this PR introduce?

  • fix: represents bug fixes
  • refactor: represents production code refactoring
  • feat: represents a new feature
  • docs: documentation changes (no production code change)
  • chore: maintenance tasks (no production code change)
  • test: all about tests: adding, refactoring tests (no production code change)
  • other... Please describe:

Does this PR introduce a breaking change?

  • Yes
  • No
  • Maybe (not 100% sure => check with FE)

Does this PR change client-test-data?

  • Yes (don't forget to update the JS-LIB team about the change)
  • No

@BalduinLandolt BalduinLandolt self-assigned this Aug 9, 2023
@codecov
Copy link

codecov bot commented Aug 9, 2023

Codecov Report

All modified lines are covered by tests ✅

Comparison is base (59d18ce) 87.25% compared to head (d46a2e7) 21.95%.

Additional details and impacted files
@@                                          Coverage Diff                                          @@
##           wip/DEV-2273-add-new-text-value-classes-to-knora-base-ontology-2    #2780       +/-   ##
=====================================================================================================
- Coverage                                                             87.25%   21.95%   -65.30%     
=====================================================================================================
  Files                                                                   243      244        +1     
  Lines                                                                 23960    23970       +10     
=====================================================================================================
- Hits                                                                  20906     5263    -15643     
- Misses                                                                 3054    18707    +15653     
Files Coverage Δ
.../org/knora/webapi/messages/OntologyConstants.scala 98.78% <ø> (-0.98%) ⬇️
.../org/knora/webapi/messages/StandoffConstants.scala 0.00% <ø> (ø)
...webapi/messages/util/ConstructResponseUtilV2.scala 0.89% <ø> (-88.70%) ⬇️
...earch/types/InferringGravsearchTypeInspector.scala 3.12% <ø> (-88.00%) ⬇️
...esponder/resourcemessages/ResourceMessagesV2.scala 0.00% <ø> (-90.31%) ⬇️
...s/v2/responder/valuemessages/ValueMessagesV2.scala 0.00% <ø> (-77.59%) ⬇️
...ra/webapi/responders/v2/ResourcesResponderV2.scala 1.26% <ø> (-86.99%) ⬇️
...ora/webapi/responders/v2/StandoffResponderV2.scala 3.59% <ø> (-75.05%) ⬇️
...knora/webapi/responders/v2/ValuesResponderV2.scala 1.60% <ø> (-92.33%) ⬇️
...plestore/upgrade/plugins/UpgradePluginPR2710.scala 0.00% <ø> (-91.90%) ⬇️

... and 157 files with indirect coverage changes

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@BalduinLandolt BalduinLandolt force-pushed the textvalues/apply-new-model-to-test-data branch 3 times, most recently from 1f1f775 to 14c62b1 Compare August 22, 2023 10:33
@BalduinLandolt BalduinLandolt force-pushed the textvalues/apply-new-model-to-test-data branch from 3ea8839 to d77f1cb Compare August 24, 2023 10:17
@BalduinLandolt BalduinLandolt force-pushed the textvalues/apply-new-model-to-test-data branch from ee36da5 to 55f735b Compare August 29, 2023 09:47
@BalduinLandolt BalduinLandolt deleted the textvalues/apply-new-model-to-test-data branch January 15, 2024 07:37
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant