-
Notifications
You must be signed in to change notification settings - Fork 18
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fix(api-v2): Fix custom datatypes in knora-api simple ontology #1601
Conversation
- Add a definition for rdfs:label so it can be used in cardinalities.
knora-api-js-lib uses the complex schema. But it is better to be sure. Could you regenerate and integrate the client code and test data and see if there is any relevant change or if they unit tests break? see https://github.com/dasch-swiss/knora-api-js-lib/blob/master/Makefile for detailed instructions. |
The generated client code and test data are all in the complex schema. Also, I'm about to do a PR to remove the client code generation... |
I know. I need some instructions how to generate the test data for admin and v2. Or will the route stay the same? |
I'll try to change it as little as possible. |
If this PR has no effects on data in the complex schema, it won't affect knora-api-lib-js. But as I said, it is better to try it out ;-) |
It doesn't affect data at all, only the |
great, so this should be easy |
Do you want me to try it out just to be sure? |
Yes please, if you have time. |
ok, will do |
looks fine, there is just a new element in
|
OK to merge this then? |
@tobiasschweizer Thanks very much for your help with this. |
This PR:
knora-api
ontology in the simple schema.rdfs:label a owl:DatatypeProperty
so it can be used in cardinalities.@tobiasschweizer Do you think this will affect
knora-api-js-lib
?Fixes #1593.