fix: Respond with internal error instead of bad credentials when trip…

…lestore is down during authentication (DEV-4019) (#3342)
dasch-swiss · Aug 27, 2024 · cb3f69a · cb3f69a
1 parent 8f7172d
commit cb3f69a
Show file tree

Hide file tree

Showing 2 changed files with 6 additions and 3 deletions.
diff --git a/webapi/src/main/scala/org/knora/webapi/slice/security/Authenticator.scala b/webapi/src/main/scala/org/knora/webapi/slice/security/Authenticator.scala
@@ -226,13 +226,13 @@ final case class AuthenticatorLive(
   } yield user
 
   private def getUserByIri(iri: UserIri): IO[AuthenticatorError, User] =
-    userService.findUserByIri(iri).some.orElseFail(UserNotFound).tap(ensureActiveUser).logError
+    userService.findUserByIri(iri).orDie.someOrFail(UserNotFound).tap(ensureActiveUser)
 
   private def getUserByEmail(email: Email): IO[AuthenticatorError, User] =
-    userService.findUserByEmail(email).some.orElseFail(UserNotFound).tap(ensureActiveUser)
+    userService.findUserByEmail(email).orDie.someOrFail(UserNotFound).tap(ensureActiveUser)
 
   private def getUserByUsername(username: Username): IO[AuthenticatorError, User] =
-    userService.findUserByUsername(username).some.orElseFail(UserNotFound).tap(ensureActiveUser)
+    userService.findUserByUsername(username).orDie.someOrFail(UserNotFound).tap(ensureActiveUser)
 
   private def ensureActiveUser(user: User): IO[AuthenticatorError, Unit] = for {
     _ <- ZIO.fail(UserNotActive).when(!user.isActive)

diff --git a/...src/main/scala/org/knora/webapi/slice/security/api/AuthenticationEndpointsV2Handler.scala b/...src/main/scala/org/knora/webapi/slice/security/api/AuthenticationEndpointsV2Handler.scala
@@ -10,6 +10,7 @@ import zio.ZLayer
 
 import java.time.Instant
 
+import dsp.errors.AuthenticationException
 import dsp.errors.BadCredentialsException
 import org.knora.webapi.config.AppConfig
 import org.knora.webapi.slice.admin.domain.model.Username
@@ -51,6 +52,8 @@ case class AuthenticationEndpointsV2Handler(
         }).mapBoth(
           _ => BadCredentialsException(BAD_CRED_NOT_VALID),
           (_, token) => setCookieAndResponse(token),
+        ).catchAllDefect(e =>
+          ZIO.fail(AuthenticationException("An internal error happened during authentication", Some(e))),
         )
       },
     )