Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

test: add test runner (DEV-3173) #2

Merged
merged 1 commit into from
Jan 12, 2024
Merged

Conversation

jnussbaum
Copy link
Collaborator

No description provided.

Copy link

linear bot commented Jan 12, 2024

@jnussbaum jnussbaum self-assigned this Jan 12, 2024
@jnussbaum jnussbaum changed the title test: add test runner(DEV-3173) test: add test runner (DEV-3173) Jan 12, 2024
Copy link

@BalduinLandolt BalduinLandolt left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I seem to recall that we once had an issue with timed actions at some point stopping to execute if a repo doesn't get touched regularly (understandably, from GitHub's side of things), so that may be something to look out for.

Also, generally, chron jobs aren't super nice because you don't get immediate feedback, and things may run even if they don't hacve to. So looking into a git hook triggered solution would be nicer, even though maybe a bit more complex. (If you're curious, we have such a setup somewhere in the ARK resolver, I think... but I don't recall the details)

@jnussbaum
Copy link
Collaborator Author

I seem to recall that we once had an issue with timed actions at some point stopping to execute if a repo doesn't get touched regularly (understandably, from GitHub's side of things), so that may be something to look out for.

Also, generally, chron jobs aren't super nice because you don't get immediate feedback, and things may run even if they don't hacve to. So looking into a git hook triggered solution would be nicer, even though maybe a bit more complex. (If you're curious, we have such a setup somewhere in the ARK resolver, I think... but I don't recall the details)

The only thing I found was this: https://blog.marcnuri.com/triggering-github-actions-across-different-repositories. That would mean: in the dsp-tools repo, I send a HTTP request to this repo, with curl -X POST https://api.github.com/repos/dasch-swiss/00a1-import-scripts/dispatches ..., and this would then trigger the workflow, instead of the cronjob. I thought that's an overkill, so I didn't try it...

@BalduinLandolt
Copy link

I seem to recall that we once had an issue with timed actions at some point stopping to execute if a repo doesn't get touched regularly (understandably, from GitHub's side of things), so that may be something to look out for.
Also, generally, chron jobs aren't super nice because you don't get immediate feedback, and things may run even if they don't hacve to. So looking into a git hook triggered solution would be nicer, even though maybe a bit more complex. (If you're curious, we have such a setup somewhere in the ARK resolver, I think... but I don't recall the details)

The only thing I found was this: https://blog.marcnuri.com/triggering-github-actions-across-different-repositories. That would mean: in the dsp-tools repo, I send a HTTP request to this repo, with curl -X POST https://api.github.com/repos/dasch-swiss/00a1-import-scripts/dispatches ..., and this would then trigger the workflow, instead of the cronjob. I thought that's an overkill, so I didn't try it...

You wouldn't have to do curl, in the DSP-TOOLS repo you could activate a webhook, which would do the HTTP request for you (see here for an example: https://github.com/dasch-swiss/ark-resolver-data/settings/hooks/80842207?tab=settings ). But if you think it's overkill, we can see how it goes with the cron job.

@jnussbaum jnussbaum merged commit d2deb9b into main Jan 12, 2024
1 check passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants