Fix analyzer failures #364
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
natebosch
reviewed
May 17, 2024
| channel.stream.listen(expectAsync1((message) { | ||
| expect(message, equals('pong')); | ||
| channel.sink.close(3678, 'raisin'); | ||
| }), onDone: expectAsync0(() {})); |
There was a problem hiding this comment.
Can you expand on what failed here? Why can these streams now emit more than once? How does this relate to the analyzer?
There was a problem hiding this comment.
During the downgrade analysis, the failure was:
Analyzing web_socket_channel...
info - test/io_test.dart:74:1[9](https://github.com/dart-lang/web_socket_channel/actions/runs/9133840767/job/25118162898?pr=363#step:5:10) - The value of the argument is redundant because it matches the default value. Try removing the argument. - avoid_redundant_argument_values
info - test/io_test.dart:[10](https://github.com/dart-lang/web_socket_channel/actions/runs/9133840767/job/25118162898?pr=363#step:5:11)1:19 - The value of the argument is redundant because it matches the default value. Try removing the argument. - avoid_redundant_argument_values
There was a problem hiding this comment.
We should just drop --fatal-infos w/ downgrade, I think!
1 task
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Contribution guidelines:
dart format.Note that many Dart repos have a weekly cadence for reviewing PRs - please allow for some latency before initial review feedback.