Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

coverage: Allow specifying coverage flags via a yaml file #1954

Open
wants to merge 11 commits into
base: main
Choose a base branch
from

Conversation

Dhruv-Maradiya
Copy link
Contributor

@Dhruv-Maradiya Dhruv-Maradiya commented Dec 31, 2024

PR Description

Overview

Concerns

  • parseArgs Handling:
    The parseArgs function is defined as private, preventing it from being imported into test files. As a workaround, I created a minimal version for testing purposes. I am wondering if there is a more efficient way to handle this.

  • Test Coverage:
    I have added test cases to validate the new functionality. I'm unsure if I have organized the tests properly and would appreciate feedback on their coverage and structure.


  • I’ve reviewed the contributor guide and applied the relevant portions to this PR.

Copy link

github-actions bot commented Jan 8, 2025

Package publishing

Package Version Status Publish tag (post-merge)
package:coverage 1.12.0 ready to publish coverage-v1.12.0
package:graphs 2.3.3-wip WIP (no publish necessary)
package:boolean_selector 2.1.2 already published at pub.dev
package:browser_launcher 1.1.3 already published at pub.dev
package:cli_config 0.2.1-wip WIP (no publish necessary)
package:cli_util 0.4.2 already published at pub.dev
package:clock 1.1.2 already published at pub.dev
package:code_builder 4.10.1 already published at pub.dev
package:benchmark_harness 2.3.1 already published at pub.dev
package:csslib 1.0.2 already published at pub.dev
package:extension_discovery 2.1.0 already published at pub.dev
package:file 7.0.2-wip WIP (no publish necessary)
package:file_testing 3.1.0-wip WIP (no publish necessary)
package:bazel_worker 1.1.3-wip WIP (no publish necessary)
package:html 0.15.5 already published at pub.dev
package:io 1.0.5 already published at pub.dev
package:json_rpc_2 3.0.3 already published at pub.dev
package:markdown 7.3.1-wip WIP (no publish necessary)
package:mime 2.0.0 already published at pub.dev
package:oauth2 2.0.4-wip WIP (no publish necessary)
package:package_config 2.1.1 already published at pub.dev
package:pool 1.5.2-wip WIP (no publish necessary)
package:pub_semver 2.1.5 already published at pub.dev
package:pubspec_parse 1.5.0 already published at pub.dev
package:source_map_stack_trace 2.1.3-wip WIP (no publish necessary)
package:yaml_edit 2.2.2 already published at pub.dev
package:source_span 1.10.1 already published at pub.dev
package:sse 4.1.7 already published at pub.dev
package:stack_trace 1.12.1 already published at pub.dev
package:stream_channel 2.1.4 already published at pub.dev
package:stream_transform 2.1.2-wip WIP (no publish necessary)
package:string_scanner 1.4.1 already published at pub.dev
package:term_glyph 1.2.3-wip WIP (no publish necessary)
package:test_reflective_loader 0.2.3 already published at pub.dev
package:timing 1.0.2 already published at pub.dev
package:unified_analytics 7.0.1 already published at pub.dev
package:watcher 1.1.1 already published at pub.dev
package:yaml 3.1.3 already published at pub.dev
package:source_maps 0.10.14-wip WIP (no publish necessary)

Documentation at https://github.com/dart-lang/ecosystem/wiki/Publishing-automation.

Copy link

github-actions bot commented Jan 8, 2025

PR Health

Breaking changes ✔️
Package Change Current Version New Version Needed Version Looking good?
coverage Non-Breaking 1.11.1 1.12.0-wip 1.12.0 ✔️
Changelog Entry ✔️
Package Changed Files

Changes to files need to be accounted for in their respective changelogs.

Coverage ⚠️
File Coverage
pkgs/coverage/bin/collect_coverage.dart 💔 Not covered
pkgs/coverage/bin/format_coverage.dart 💔 5 % ⬇️ 5 %
pkgs/coverage/bin/test_with_coverage.dart 💔 Not covered
pkgs/coverage/lib/src/coverage_options.dart 💚 93 %

This check for test coverage is informational (issues shown here will not fail the PR).

This check can be disabled by tagging the PR with skip-coverage-check.

API leaks ✔️

The following packages contain symbols visible in the public API, but not exported by the library. Export these symbols or remove them from your publicly visible API.

Package Leaked API symbols
License Headers ⚠️
// Copyright (c) 2025, the Dart project authors. Please see the AUTHORS file
// for details. All rights reserved. Use of this source code is governed by a
// BSD-style license that can be found in the LICENSE file.
Files
pkgs/coverage/lib/src/coverage_options.dart
pkgs/coverage/test/collect_coverage_config_test.dart

All source files should start with a license header.

Unrelated files missing license headers
Files
pkgs/bazel_worker/benchmark/benchmark.dart
pkgs/bazel_worker/example/client.dart
pkgs/bazel_worker/example/worker.dart
pkgs/benchmark_harness/integration_test/perf_benchmark_test.dart
pkgs/boolean_selector/example/example.dart
pkgs/clock/lib/clock.dart
pkgs/clock/lib/src/clock.dart
pkgs/clock/lib/src/default.dart
pkgs/clock/lib/src/stopwatch.dart
pkgs/clock/lib/src/utils.dart
pkgs/clock/test/clock_test.dart
pkgs/clock/test/default_test.dart
pkgs/clock/test/stopwatch_test.dart
pkgs/clock/test/utils.dart
pkgs/html/example/main.dart
pkgs/html/lib/dom.dart
pkgs/html/lib/dom_parsing.dart
pkgs/html/lib/html_escape.dart
pkgs/html/lib/parser.dart
pkgs/html/lib/src/constants.dart
pkgs/html/lib/src/encoding_parser.dart
pkgs/html/lib/src/html_input_stream.dart
pkgs/html/lib/src/list_proxy.dart
pkgs/html/lib/src/query_selector.dart
pkgs/html/lib/src/token.dart
pkgs/html/lib/src/tokenizer.dart
pkgs/html/lib/src/treebuilder.dart
pkgs/html/lib/src/utils.dart
pkgs/html/test/dom_test.dart
pkgs/html/test/parser_feature_test.dart
pkgs/html/test/parser_test.dart
pkgs/html/test/query_selector_test.dart
pkgs/html/test/selectors/level1_baseline_test.dart
pkgs/html/test/selectors/level1_lib.dart
pkgs/html/test/selectors/selectors.dart
pkgs/html/test/support.dart
pkgs/html/test/tokenizer_test.dart
pkgs/pubspec_parse/test/git_uri_test.dart
pkgs/stack_trace/example/example.dart
pkgs/watcher/test/custom_watcher_factory_test.dart
pkgs/yaml_edit/example/example.dart

This check can be disabled by tagging the PR with skip-license-check.

@liamappelbe liamappelbe self-requested a review January 12, 2025 22:40
Copy link
Contributor

@liamappelbe liamappelbe left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks like there's some test failures. See if you can reproduce them locally.

https://github.com/dart-lang/tools/actions/runs/12686464325/job/35499098457?pr=1954

pkgs/coverage/CHANGELOG.md Outdated Show resolved Hide resolved
pkgs/coverage/lib/src/coverage_options.dart Show resolved Hide resolved
pkgs/coverage/lib/src/coverage_options.dart Outdated Show resolved Hide resolved
@Dhruv-Maradiya
Copy link
Contributor Author

Hi @liamappelbe

I've implemented the mentioned changes, and all test cases passed successfully locally. I look forward to your review. Thank you!

pkgs/coverage/CHANGELOG.md Outdated Show resolved Hide resolved
pkgs/coverage/bin/test_with_coverage.dart Outdated Show resolved Hide resolved
pkgs/coverage/lib/src/coverage_options.dart Outdated Show resolved Hide resolved
pkgs/coverage/lib/src/coverage_options.dart Outdated Show resolved Hide resolved
pkgs/coverage/lib/src/coverage_options.dart Outdated Show resolved Hide resolved
pkgs/coverage/lib/src/coverage_options.dart Outdated Show resolved Hide resolved
pkgs/coverage/lib/src/coverage_options.dart Outdated Show resolved Hide resolved
@coveralls
Copy link

Pull Request Test Coverage Report for Build 12831336349

Warning: This coverage report may be inaccurate.

This pull request's base commit is no longer the HEAD commit of its target branch. This means it includes changes from outside the original pull request, including, potentially, unrelated coverage changes.

Details

  • 39 of 42 (92.86%) changed or added relevant lines in 1 file are covered.
  • No unchanged relevant lines lost coverage.
  • Overall coverage decreased (-7.0%) to 93.026%

Changes Missing Coverage Covered Lines Changed/Added Lines %
pkgs/coverage/lib/src/coverage_options.dart 39 42 92.86%
Totals Coverage Status
Change from base Build 12728848832: -7.0%
Covered Lines: 667
Relevant Lines: 717

💛 - Coveralls

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Allow specifying coverage flags via a yaml file
3 participants