Enum + event constructor for pub result events

[eliasyishak]

Related to the tracker issue:

• ☂️ package:unified_analytics implementation in flutter tool flutter/flutter#128251

Implementing the class below from flutter/flutter in this package

class PubResultEvent extends UsageEvent {
  PubResultEvent({
    required String context,
    required String result,
    required Usage usage,
  }) : super('pub-result', context, label: result, flutterUsage: usage);
}

---

• I’ve reviewed the contributor guide and applied the relevant portions to this PR.

Contribution guidelines:

• See our contributor guide for general expectations for PRs.
• Larger or significant changes should be discussed in an issue before creating a PR.
• Contributions to our repos should follow the Dart style guide and use dart format.
• Most changes should add an entry to the changelog and may need to rev the pubspec package version.
• Changes to packages require corresponding tests.

Note that many Dart repos have a weekly cadence for reviewing PRs - please allow for some latency before initial review feedback.

[github-actions]

Package publishing

Package	Version	Status	Publish tag (post-merge)
package:unified_analytics	5.3.0	ready to publish	unified_analytics-v5.3.0
package:graphs	2.3.2-wip	WIP (no publish necessary)
package:cli_config	0.1.2	already published at pub.dev
package:extension_discovery	2.0.1-wip	WIP (no publish necessary)

Documentation at https://github.com/dart-lang/ecosystem/wiki/Publishing-automation.

[eliasyishak]

Unrelated dartdoc update that i wanted to include for my own reference

[christopherfujino]

not a blocker for this PR, but just wondering, do you know if long-term we would need this flutter tool event once pub has its own analytics via unified_analytics?

[eliasyishak]

Hmm that's a good question, and i would think it may still be useful to know which pub subcommands users are running within the flutter context? so yes we can track usage of dart pub get when we migrate pub, but is it also helpful to track flutter pub get?... if the answer is no, then this event likely won't be useful

From what I can see, context is just the lists from here

And result is always either "success" or "failure"

[christopherfujino]

I think this is a question for the pub team--I don't know that anyone else uses these numbers.

Note, today we're intentionally suppressing pub's own analytics (https://github.com/christopherfujino/flutter/blob/disable-flutter-build-aar-plugins/packages/flutter_tools/lib/src/dart/pub.dart#L562), so flutter pub ONLY sends Flutter analytics, but I seem to recall that not being our intended final state.

cc @jonasfj @sigurdm

[sigurdm]

We suppressed the analytics because we were unclear if the pdd covered sending dart analytics from the flutter tool.

I think with the unified analytics all should be good, and we can stop suppressing those, and potentially get actual useful data.

[eliasyishak]

Oh that's good to know, given that we now have the approvals, @christopherfujino are you in favor of deprecating this event? I think there may still be value in tracking successes/failures across different pub invocations from the flutter tool over time... while the pub team can collect more in depth analytics as well on their end.

[christopherfujino]

I am in favor of deleting it, but I will leave the final decision to the pub team, IDK if they use it or potentially would.

[eliasyishak]

Cool, I'll just close this PR for now and check offline. Will reopen if it's still necessary

[eliasyishak]

Just to loop back after conversation with @sigurdm and @jonasfj

This event can remain deprecated since we are already collecting success/failure events from the Event.flutterCommandResult call site in flutter_command.dart

[christopherfujino]

LGTM

[eliasyishak]

Closing as this event may not be necessary from the flutter tool itself since pub will soon be sending its own analytics from package:unified_analytics