Add more info into the AnalyticsException
#181
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| @@ -102,7 +123,9 @@ void checkBody(Map<String, Object?> body) { | |||
| value as String; | |||
| if (value.length > 100) { | |||
| throw AnalyticsException( | |||
| 'Limit characters in event param value to 100 chars or less'); | |||
| 'Limit characters in event param value to 100 chars or less\n' | |||
| 'Value for "$key" is too long, value="$value"', | |||
There was a problem hiding this comment.
Slight re-word for better clarity
Suggested change
| 'Value for "$key" is too long, value="$value"', | |
| 'For key "$key" the value "$value" is too long', |
christopherfujino
approved these changes
Oct 16, 2023
Co-authored-by: Christopher Fujino <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
In my testing in the flutter tool codebase, I realized that adding more info about what was causing the failure when enabling asserts would be beneficial to others working with this package and other clients of this package.
Contribution guidelines:
dart format.Note that many Dart repos have a weekly cadence for reviewing PRs - please allow for some latency before initial review feedback.