Skip to content

Commit

Permalink
Update DevTools.event constructor params
Browse files Browse the repository at this point in the history
  • Loading branch information
elliette committed Nov 7, 2024
1 parent 0482672 commit 93d9872
Show file tree
Hide file tree
Showing 4 changed files with 6 additions and 2 deletions.
2 changes: 1 addition & 1 deletion pkgs/unified_analytics/lib/src/constants.dart
Original file line number Diff line number Diff line change
Expand Up @@ -87,7 +87,7 @@ const int kMaxLogFileSize = 25 * (1 << 20);
const String kLogFileName = 'dart-flutter-telemetry.log';

/// The current version of the package, should be in line with pubspec version.
const String kPackageVersion = '6.1.5';
const String kPackageVersion = '6.1.6-wip';

/// The minimum length for a session.
const int kSessionDurationMinutes = 30;
Expand Down
2 changes: 2 additions & 0 deletions pkgs/unified_analytics/lib/src/event.dart
Original file line number Diff line number Diff line change
Expand Up @@ -399,6 +399,7 @@ final class Event {
int? rootSetCount,
int? rowCount,
int? inspectorTreeControllerId,
bool? isV2Inspector,

// DeepLinkScreenMetrics
String? androidAppId,
Expand Down Expand Up @@ -450,6 +451,7 @@ final class Event {
if (rowCount != null) 'rowCount': rowCount,
if (inspectorTreeControllerId != null)
'inspectorTreeControllerId': inspectorTreeControllerId,
if (isV2Inspector != null) 'isV2Inspector': isV2Inspector,
// DeepLinkScreenMetrics
if (androidAppId != null) 'androidAppId': androidAppId,
if (iosBundleId != null) 'iosBundleId': iosBundleId,
Expand Down
2 changes: 1 addition & 1 deletion pkgs/unified_analytics/pubspec.yaml
Original file line number Diff line number Diff line change
Expand Up @@ -5,7 +5,7 @@ description: >-
# LINT.IfChange
# When updating this, keep the version consistent with the changelog and the
# value in lib/src/constants.dart.
version: 6.1.5
version: 6.1.6-wip
# LINT.ThenChange(lib/src/constants.dart)
repository: https://github.com/dart-lang/tools/tree/main/pkgs/unified_analytics
issue_tracker: https://github.com/dart-lang/tools/issues?q=is%3Aissue+is%3Aopen+label%3Apackage%3Aunified_analytics
Expand Down
2 changes: 2 additions & 0 deletions pkgs/unified_analytics/test/event_test.dart
Original file line number Diff line number Diff line change
Expand Up @@ -587,6 +587,7 @@ void main() {
rootSetCount: 123,
rowCount: 123,
inspectorTreeControllerId: 123,
isV2Inspector: true,
androidAppId: 'androidAppId',
iosBundleId: 'iosBundleId',
);
Expand Down Expand Up @@ -624,6 +625,7 @@ void main() {
expect(constructedEvent.eventData['rootSetCount'], 123);
expect(constructedEvent.eventData['rowCount'], 123);
expect(constructedEvent.eventData['inspectorTreeControllerId'], 123);
expect(constructedEvent.eventData['isV2Inspector'], true);
expect(constructedEvent.eventData['androidAppId'], 'androidAppId');
expect(constructedEvent.eventData['iosBundleId'], 'iosBundleId');
expect(constructedEvent.eventData.length, 30);
Expand Down

0 comments on commit 93d9872

Please sign in to comment.