[native_assets_cli] Add DartCApi
#1937
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
github-actions
bot
added
package:native_assets_cli
package:native_assets_builder
labels
PR HealthBreaking changes ✔️
Changelog Entry ✔️
Changes to files need to be accounted for in their respective changelogs. API leaks ✔️The following packages contain symbols visible in the public API, but not exported by the library. Export these symbols or remove them from your publicly visible API.
License Headers ✔️
All source files should start with a license header. Unrelated files missing license headers
|
github-actions
bot
added
the
type-infra
brianquinlan
approved these changes
Jan 23, 2025
| /// Only `dart_api_dl.h` should be used. `dart_api_dl.c` shoud be compiled into | ||
| /// your `CodeAsset`. | ||
| /// | ||
| /// Note: If you're precompiling code assets, you must check that [version] is |
There was a problem hiding this comment.
This documentation might not be sufficient in the long wrong - how would I check that?
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR adds an (optional) path to the Dart C API. Both Dart and Flutter will be able to provide this.
For C code that's compiled in the hook, the path can be used directly.
For C code that's precompiled and pulled in via from a CDN, the version number should be checked in the hook.
Does not yet update the example in pkgs/native_assets_cli/example/build/use_dart_api/ because it's run against the released Dart and Flutter on CI. We should update it after Dart and Flutter pass in the API.
Bug: #839