[tool] Swap dependencies to published at specific version #1503
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
PR HealthBreaking changes ✔️
Changelog Entry ✔️
Changes to files need to be accounted for in their respective changelogs. API leaks ✔️The following packages contain symbols visible in the public API, but not exported by the library. Export these symbols or remove them from your publicly visible API.
License Headers ✔️
All source files should start with a license header. Unrelated files missing license headers
Package publish validation ✔️
Documentation at https://github.com/dart-lang/ecosystem/wiki/Publishing-automation. |
HosseinYousefi
approved these changes
Sep 3, 2024
| (# )?$packageName: | ||
| (# )? path: ([./]*)$packageName/'''); | ||
| final match = regex.firstMatch(pubspec); | ||
| if (match == null) { |
There was a problem hiding this comment.
Maybe print a warning in this case (also for the other command)
There was a problem hiding this comment.
Not every pubspec contains every package as dependency.
| print('Wrong package name.'); | ||
| return; | ||
| } | ||
| final newVersion = arguments[2]; |
There was a problem hiding this comment.
Consider GETting the latest version from pub if not explicitly provided.
There was a problem hiding this comment.
Yeah many ways to improve this script until there are no manual steps. Will do that as I use the script in the future.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Since we need a stack of PRs every time we publish, this step takes a package name as argument.