Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

9 - type_annotate_public_apis lint #1299

Closed
wants to merge 1 commit into from
Closed

9 - type_annotate_public_apis lint #1299

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
1 change: 0 additions & 1 deletion pkgs/jnigen/analysis_options.yaml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -20,7 +20,6 @@ linter:
unawaited_futures: true
prefer_const_constructors: true
prefer_relative_imports: true
type_annotate_public_apis: false # TODO(https://github.com/dart-lang/native/issues/1282): Fix.
unnecessary_lambdas: false # TODO(https://github.com/dart-lang/native/issues/1282): Fix.
unnecessary_parenthesis: false # TODO(https://github.com/dart-lang/native/issues/1282): Fix.
unreachable_from_main: false # TODO(https://github.com/dart-lang/native/issues/1282): Fix.
2 changes: 1 addition & 1 deletion pkgs/jnigen/lib/src/bindings/unnester.dart
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -13,7 +13,7 @@ class Unnester extends Visitor<Classes, void> {
const Unnester();

@override
void visit(node) {
void visit(Classes node) {
final classProcessor = _ClassUnnester();
for (final classDecl in node.decls.values) {
classDecl.accept(classProcessor);
Expand Down
4 changes: 2 additions & 2 deletions pkgs/jnigen/test/simple_package_test/generate.dart
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -21,9 +21,9 @@ const preamble = '''

''';

var javaPrefix = join('com', 'github', 'dart_lang', 'jnigen');
final javaPrefix = join('com', 'github', 'dart_lang', 'jnigen');

var javaFiles = [
final javaFiles = [
join(javaPrefix, 'simple_package', 'Example.java'),
join(javaPrefix, 'pkg2', 'C2.java'),
join(javaPrefix, 'pkg2', 'Example.java'),
Expand Down