Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update package:intl4x #842

Merged
merged 6 commits into from
May 28, 2024
Merged

Update package:intl4x #842

merged 6 commits into from
May 28, 2024

Conversation

mosuem
Copy link
Member

@mosuem mosuem commented May 27, 2024

Update to the newest versions of icu4x and native_assets_cli.


  • I’ve reviewed the contributor guide and applied the relevant portions to this PR.
Contribution guidelines:

Note that many Dart repos have a weekly cadence for reviewing PRs - please allow for some latency before initial review feedback.

Copy link

github-actions bot commented May 27, 2024

PR Health

Breaking changes ✔️

Details
Package Change Current Version New Version Needed Version Looking good?
intl4x Breaking 0.8.2 0.9.0 0.9.0 ✔️

Changelog Entry ✔️

Details
Package Changed Files

Changes to files need to be accounted for in their respective changelogs.

Coverage ⚠️

Details
File Coverage
pkgs/intl4x/example/web/main.dart 💔 Not covered
pkgs/intl4x/hook/build.dart 💔 Not covered
pkgs/intl4x/lib/intl4x.dart 💚 100 %
pkgs/intl4x/lib/src/collation/collation_4x.dart 💚 100 %
pkgs/intl4x/lib/src/datetime_format/datetime_format.dart 💚 100 %
pkgs/intl4x/lib/src/list_format/list_format_4x.dart 💚 100 %
pkgs/intl4x/lib/src/number_format/number_format.dart 💚 100 %
pkgs/intl4x/lib/src/plural_rules/plural_rules_4x.dart 💚 100 %

This check for test coverage is informational (issues shown here will not fail the PR).

This check can be disabled by tagging the PR with skip-coverage-check.

API leaks ✔️

Details

The following packages contain symbols visible in the public API, but not exported by the library. Export these symbols or remove them from your publicly visible API.

Package Leaked API symbols

License Headers ✔️

Details
// Copyright (c) 2024, the Dart project authors. Please see the AUTHORS file
// for details. All rights reserved. Use of this source code is governed by a
// BSD-style license that can be found in the LICENSE file.
Files
no missing headers

All source files should start with a license header.

Package publish validation ✔️

Details
Package Version Status
package:intl4x 0.9.0 ready to publish
package:intl 0.20.0-wip WIP (no publish necessary)
package:intl_translation 0.20.0 already published at pub.dev
package:messages 0.2.0 already published at pub.dev
package:messages_builder 0.2.1 already published at pub.dev
package:messages_serializer 0.2.1 already published at pub.dev
package:messages_shrinker 0.2.2-wip WIP (no publish necessary)

Documentation at https://github.com/dart-lang/ecosystem/wiki/Publishing-automation.

Copy link

github-actions bot commented May 27, 2024

Package publishing

Package Version Status Publish tag (post-merge)
package:intl4x 0.9.0 ready to publish intl4x-v0.9.0
package:intl 0.20.0-wip WIP (no publish necessary)
package:intl_translation 0.20.0 already published at pub.dev
package:messages 0.2.0 already published at pub.dev
package:messages_builder 0.2.1 already published at pub.dev
package:messages_serializer 0.2.1 already published at pub.dev
package:messages_shrinker 0.2.2-wip WIP (no publish necessary)

Documentation at https://github.com/dart-lang/ecosystem/wiki/Publishing-automation.

@mosuem mosuem requested a review from dcharkes May 27, 2024 11:21
'fetch' || null => FetchMode(libPath),
String() => throw ArgumentError('''
await build(args, (config, output) async {
final buildMode = switch (Platform.environment['ICU4X_BUILD_MODE']) {

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

(Not related to this PR.)
We should think about whether environment variables should be passed on to hooks at all, and how they influence caching. Currently, they are passed in, but not considered in caching, which is most likely broken.

@mosuem mosuem merged commit ee74bda into main May 28, 2024
15 checks passed
@mosuem mosuem deleted the updateIntl4x branch May 28, 2024 11:58
mosuem added a commit that referenced this pull request May 28, 2024
commit ee74bda
Author: Moritz <[email protected]>
Date:   Tue May 28 13:58:14 2024 +0200

    Update `package:intl4x` (#842)

    * Update `package:intl4x`

    * Use const constructors

    * Add changelog

    * Fix missing exports

    * Fix imports

    * Rev version
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants