Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

testing qodana #2

Closed
wants to merge 1 commit into from
Closed

testing qodana #2

wants to merge 1 commit into from

Conversation

darrenvechain
Copy link
Owner

@darrenvechain darrenvechain commented Dec 21, 2023

PR-Codex overview

Focus of the PR:

This PR focuses on adding necessary configuration files and updating the Makefile for the project.

Detailed summary:

  • Added .idea/thor.iml file with Go component enabled.
  • Added .idea/ktfmt.xml file with KtfmtSettings component enabled.
  • Added .idea/vcs.xml file with VcsDirectoryMappings component enabled.
  • Updated Makefile to remove bin/thor and add bin/disco.
  • Added test-coverage target to Makefile.
  • Added .idea/modules.xml file with ProjectModuleManager component enabled.
  • Added .idea/project.iml file with Go component enabled.
  • Added .github/workflows/qodana-analysis.yaml file for GitHub Actions.
  • Added .idea/watcherTasks.xml file with golangci-lint task options.
  • Added .idea/workspace.xml file with various component configurations.

✨ Ask PR-Codex anything about this PR by commenting with /codex {your question}

Copy link

Qodana for Go

1333 new problems were found

Inspection name Severity Problems
Unused parameter 🔶 Warning 570
Imported package name as a name identifier 🔶 Warning 171
Unhandled error 🔶 Warning 139
Unused exported function 🔶 Warning 93
Redundant types in composite literals 🔶 Warning 31
Deprecated element 🔶 Warning 30
Unused constant 🔶 Warning 27
Unused global variable 🔶 Warning 17
Reserved word used as name 🔶 Warning 8
Unexported return type of the exported function 🔶 Warning 5
Unused function 🔶 Warning 5
Missing 'case' statements for 'iota' consts in 'switch' 🔶 Warning 3
Bool condition 🔶 Warning 2
Leading whitespace in directive comment 🔶 Warning 1
Unused type 🔶 Warning 1
Receiver has a generic name ◽️ Notice 98
Mixed value and pointer receivers ◽️ Notice 63
Comment of exported element starts with the incorrect name ◽️ Notice 25
Usage of Snake_Case ◽️ Notice 19
Redundant type conversion ◽️ Notice 7
Error string should not be capitalized or end with punctuation ◽️ Notice 6
Redundant parentheses ◽️ Notice 5
Empty slice declared using a literal ◽️ Notice 4
Name starts with a package name ◽️ Notice 1
Redundant import alias ◽️ Notice 1
Type can be omitted ◽️ Notice 1

💡 Qodana analysis was run in the pull request mode: only the changed files were checked
☁️ View the detailed Qodana report

Contact Qodana team

Contact us at [email protected]

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant