Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore: add go linting #15

Closed
wants to merge 10 commits into from
Closed

chore: add go linting #15

wants to merge 10 commits into from

Conversation

darrenvechain
Copy link
Owner

@darrenvechain darrenvechain commented Jan 8, 2024

Description

Please include a summary of the changes and the related issue. Please also include relevant motivation and context. List any dependencies that are required for this change.

Fixes # (issue)

Type of change

Please delete options that are not relevant.

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to not work as expected)
  • This change requires a documentation update

How Has This Been Tested?

Please describe the tests that you ran to verify your changes. Provide instructions so we can reproduce. Please also list any relevant details for your test configuration

  • Test A
  • Test B

Test Configuration:

  • Go Version:
  • Hardware:
  • Docker Version:

Checklist:

  • My code follows the style guidelines of this project
  • I have performed a self-review of my code
  • I have commented my code, particularly in hard-to-understand areas
  • I have made corresponding changes to the documentation
  • My changes generate no new warnings
  • I have added tests that prove my fix is effective or that my feature works
  • New and existing unit tests pass locally with my changes
  • New and existing E2E tests pass locally with my changes
  • Any dependent changes have been merged and published in downstream modules
  • I have not added any vulnerable dependencies to my code

PR-Codex overview

This PR focuses on code cleanup and improvements.

Detailed summary

  • Updated gfpNeg function declaration in gfp_decl.go
  • Updated golangci.yml configuration file
  • Added error handling and path validation in Load and Save functions in blocklist.go
  • Updated imports and error handling in tx_pool.go
  • Updated error handling in fetchBlocklistLoop function in tx_pool.go
  • Updated codeql.yml configuration file
  • Updated bindataRead function in bindata.go
  • Updated generateRandomID function in rpc.go
  • Updated bindataRead function in bindata.go
  • Updated MarkTransaction function in peer.go
  • Updated Slice function in peer.go
  • Updated golangci job in lint-go.yaml
  • Updated error handling and path validation in newP2PComm function in utils.go
  • Updated error handling and file reading in startAPIServer function in utils.go

✨ Ask PR-Codex anything about this PR by commenting with /codex {your question}

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant