added an extra check that Lm isn't under-constrained

darrenjw · Oct 30, 2024 · b815750 · b815750
1 parent 77c18e1
commit b815750
Show file tree

Hide file tree

Showing 2 changed files with 2 additions and 1 deletion.
diff --git a/build.sbt b/build.sbt
@@ -34,7 +34,7 @@ resolvers ++= Seq(
 
 scalaVersion := "3.3.3"
 
-crossScalaVersions := Seq("2.12.19", "2.13.13", "3.3.3")
+crossScalaVersions := Seq("2.12.19", "2.13.14", "3.3.3")
 
 ThisBuild / versionScheme := Some("strict")
 

diff --git a/src/main/scala/scalaglm/Lm.scala b/src/main/scala/scalaglm/Lm.scala
@@ -41,6 +41,7 @@ case class Lm(y: DVD,
   val X = if (addIntercept) DenseMatrix.horzcat(
     DenseVector.ones[Double](Xmat.rows).toDenseMatrix.t, Xmat)
   else Xmat
+  require(X.rows >= X.cols)
 
   /** 
     * Column names (including intercept)