This repository has been archived by the owner on Oct 1, 2024. It is now read-only.
Fix incorrect PHONY and add PHONY linter #379
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
One of the make PHONY targets was incorrect, so I fixed it and added a linter that would have caught the error.
This adds a fairly standard Makefile config that is better suited to non-C projects and is safer than the defaults. This also changes the default target to a more standard "build" step instead of "clean". Now the pattern of "make clean; make; make test" works as expected.
benji-york
changed the title
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Hi, while evaluating Ward to use in my projects, I noticed a small bug in the Makefile so I thought I'd fix it.
I also took the liberty of improving (IMHO) the Makefile just a little.
Thanks for Ward—I'm really liking what I'm seeing!