-
Notifications
You must be signed in to change notification settings - Fork 75
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Update content/print/overview.md #662
Open
alikstimix
wants to merge
3
commits into
darktable-org:master
Choose a base branch
from
alikstimix:patch-3
base: master
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Open
Changes from all commits
Commits
Show all changes
3 commits
Select commit
Hold shift + click to select a range
File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Is there a reason for removing this "important" paragraph?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Well the text is pretty opaque, and its hard to see what relevance it has to the user. It seems to be describing an aspect of the workflow of the module, and is not something the user can affect.
Maybe its of use to whoever is maintaning the module, but even then it needs a rewrite.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
It looks to be useful information for users and I'm pretty sure I understand what it's saying (you cannot use manufacturer-produced ICC profiles because they're designed for the manufacturer-produced printer drivers -- i.e. for Window$ and/or Mac) . If you don't understand it, that's not necessarily a reason to remove it.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Chris, You and I may understand it, but we are not the target audience for the user manual.
Users come to the print overview because they want to understand dt printing better, or have a particular problem. Therefore the text should be accessible to an intelligent non-specialist.
If the user doesn't already know what an ICC profile is, then the text in question is unlikely to be relevant to their problems, and the warning is superfluous.
If they do know a bit about ICC profiles then, in my opinion, the text is imprecise and in some ways self contradicting.
"this module supports the printer's ICC profile . . ." probably means "this module *uses . . . " and the rest of the sentence just states the obvious.
The sentence about not using the printer ICC profile on Linux is hard to understand. I only run Linux , so where does the profile fit in to my print workflow? Also, dt does not provide any means to directly access the printer profile, so what is the text warning against? If the user really wants to try to reuse the printer ICC profile, they must already have some knowledge and expertise outside of dt in order to get hold of it. In which case they wouldnt be asking the dt manual for help.
So anyway, my feeling is that the text would be much clearer and potentially more useful if it included a description of the dt workflow for printing - explaining why multiple ICC profiles are needed and how dt interacts with printer drivers. In this case, I don't think the text belongs in a section called "overview" but potentially in a new section called Print Workflow, that can include more technical information.
Overall I am just providing feedback and suggestions, you are the gatekeeper - your call!