Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Replace paste0 by make_canvas_url #65

Open
wants to merge 1 commit into
base: master
Choose a base branch
from

Conversation

vanatteveldt
Copy link
Contributor

I noticed the group functions no longer worked (at least get_groups_context and get_group_categories), giving a 404 because of a wrongly constructed URL:

[1] "https://canvas.vu.nl/api/v1courses/72446/groups"

(note the missing slash after /api/v1)

I figured that that the rcanvas:::canvas_url() was probably changed to no longer have a trailing slash. In any case, other methods seemed to use make_canvas_url instead of manually pasting the components, so I changed all functions in that source file to use this function instead.

Please note that I've tested this for the get_* functions, but as I don't have access to a test environment I did not test the membership changing functions, but the code changes look trivial enough to me :D

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant