Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I noticed the group functions no longer worked (at least get_groups_context and get_group_categories), giving a 404 because of a wrongly constructed URL:
[1] "https://canvas.vu.nl/api/v1courses/72446/groups"
(note the missing slash after /api/v1)
I figured that that the
rcanvas:::canvas_url()
was probably changed to no longer have a trailing slash. In any case, other methods seemed to usemake_canvas_url
instead of manually pasting the components, so I changed all functions in that source file to use this function instead.Please note that I've tested this for the get_* functions, but as I don't have access to a test environment I did not test the membership changing functions, but the code changes look trivial enough to me :D