-
Notifications
You must be signed in to change notification settings - Fork 40
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Connect wallet feature (BLOCKED) #872
Draft
pablomendezroyo
wants to merge
5
commits into
master
Choose a base branch
from
pablo/connect-wallet
base: master
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Draft
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
3 tasks
DAppNode bot has built and pinned the release to an IPFS node, for commit: 4162db2 This is a development version and should only be installed for testing purposes, install link
(by dappnodebot/build-action) |
pablomendezroyo
force-pushed
the
pablo/connect-wallet
branch
from
November 24, 2022 12:21
a8d11fd
to
e6d2d5d
Compare
pablomendezroyo
added
P2
Worth doing eventually, no rush
ethereum
Tasks related to the dappmanager core functionality Ethereum
labels
Nov 24, 2022
pablomendezroyo
force-pushed
the
pablo/connect-wallet
branch
from
November 29, 2022 15:11
e6d2d5d
to
bade728
Compare
pablomendezroyo
changed the title
Connect wallet feature (blocked)
Connect wallet feature (ON HOLD)
May 9, 2023
pablomendezroyo
changed the title
Connect wallet feature (ON HOLD)
Connect wallet feature (BLOCKED)
May 9, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
UIX improvement
This PR aims to facilitate to the user how to connect his/her wallet to any RPC endpoint of a package. Right now the procedure is:
Ideally, the user would just need to click a button and a new pop-up from metamask would get into action asking to add a new network called "DAppNode geth" or similar with all those values already fulfilled. This is possible to achieve with
switchEthereumChain
andaddEthereumChain
from the Metamask API: https://docs.metamask.io/guide/rpc-api.html#usage-with-wallet-switchethereumchainThe result should look something similar to
Blockers
Upstream discussion: