Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Connect wallet feature (BLOCKED) #872

Draft
wants to merge 5 commits into
base: master
Choose a base branch
from

Conversation

pablomendezroyo
Copy link
Contributor

@pablomendezroyo pablomendezroyo commented Aug 17, 2021

UIX improvement

This PR aims to facilitate to the user how to connect his/her wallet to any RPC endpoint of a package. Right now the procedure is:

  • Get the RPC endpoint from the package view
  • Get the chain ID of the blockchain app
  • Open a wallet provider such as metamask and create a new network based on these values

Ideally, the user would just need to click a button and a new pop-up from metamask would get into action asking to add a new network called "DAppNode geth" or similar with all those values already fulfilled. This is possible to achieve with switchEthereumChain and addEthereumChain from the Metamask API: https://docs.metamask.io/guide/rpc-api.html#usage-with-wallet-switchethereumchain

The result should look something similar to
image

Blockers

  • No possible to add a new network with a chain ID mark as "default" by Metamask: Ethereum mainnet (0x1), Rinkeby (0x4), Goerli (0x5), Ropsten (0x3) and Koban()
  • Not possible to use RPC urls without HTTPS. Can be solved with HTTPS portal

Upstream discussion:

@pablomendezroyo pablomendezroyo marked this pull request as draft August 17, 2021 07:48
@pablomendezroyo pablomendezroyo self-assigned this Aug 17, 2021
@pablomendezroyo pablomendezroyo linked an issue Aug 17, 2021 that may be closed by this pull request
3 tasks
@github-actions
Copy link

github-actions bot commented Aug 17, 2021

@github-actions
Copy link

github-actions bot commented Sep 21, 2021

DAppNode bot has built and pinned the release to an IPFS node, for commit: 4162db2

This is a development version and should only be installed for testing purposes, install link

/ipfs/QmbPqsXRYCrak8XjTZmJq2hxvxmoZ3NrtESSu5oBwv84Rb

(by dappnodebot/build-action)

@pablomendezroyo pablomendezroyo added P2 Worth doing eventually, no rush ethereum Tasks related to the dappmanager core functionality Ethereum labels Nov 24, 2022
@pablomendezroyo pablomendezroyo linked an issue Nov 24, 2022 that may be closed by this pull request
@github-actions github-actions bot temporarily deployed to commit November 29, 2022 16:21 Inactive
@pablomendezroyo pablomendezroyo changed the title Connect wallet feature (blocked) Connect wallet feature (ON HOLD) May 9, 2023
@pablomendezroyo pablomendezroyo changed the title Connect wallet feature (ON HOLD) Connect wallet feature (BLOCKED) May 9, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
ethereum Tasks related to the dappmanager core functionality Ethereum P2 Worth doing eventually, no rush
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Add Metamask extension for ETH client packages Implement connect wallet in the dashboard
1 participant