ui changes for dark mode #1459
Open
ui changes for dark mode #1459
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@RomiRand looks like there are some issues in the css code |
|
Sorry, my bad! fixed :) |
|
@dsimog01 did you manually check the frontend changes? |
|
@pablomendezroyo any updates on this? Should I do something else? |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Context
This small PR makes some changes to the dark mode UI. It fixes some unreadable color combinations and makes everything more consistent with the light theme.
Approach
Should fix #1414, among other things (I didn't only change the text color but also background, because the colors would be too bright; oriented on the already existing banner colors). I used my best judgement to select fitting colors, but that's subjective of course.
Test instructions
Major improvements are the alerts banners, some of them were almost not readable, for example the "All packages are up to date" banner on the main dashboard. Another issue was the VPN credentials section in the VPN -> Wireguard -> Get link tab. The support tab also looks cleaner now, for example.