Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[ ON HOLD] Uninstall dappnode on error #342

Draft
wants to merge 1 commit into
base: master
Choose a base branch
from
Draft

[ ON HOLD] Uninstall dappnode on error #342

wants to merge 1 commit into from

Conversation

pablomendezroyo
Copy link
Contributor

@pablomendezroyo pablomendezroyo commented Aug 25, 2021 •
edited by sync-by-unito bot
Loading

  • Catch exit signal
  • call dappnode uninstaller on exit

┆Issue is synchronized with this Basecamp todo by Unito

@pablomendezroyo pablomendezroyo self-assigned this Aug 25, 2021
@pablomendezroyo pablomendezroyo added the installer This issue is related to the installer label Aug 25, 2021
@pablomendezroyo pablomendezroyo linked an issue Aug 25, 2021 that may be closed by this pull request
Uninstall dappnode and Exit if dappnode_install.sh fails #312
Open
4 tasks
@dapplion
Copy link
Contributor

@eduadiez @3alpha Could this have un-intended consequences? What is the uninstall script removing?

@pablomendezroyo
Copy link
Contributor Author

@eduadiez @3alpha Could this have un-intended consequences? What is the uninstall script removing?

maybe would be safer to just uninstall dappnode on error if the installation was done from script method, since this method is commonly used on personal hardware not purchased from dappnode

@pablomendezroyo pablomendezroyo changed the title Uninstall dappnode on error [ ON HOLD] Uninstall dappnode on error May 11, 2023
@pablomendezroyo pablomendezroyo marked this pull request as draft May 11, 2023 08:27
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@dapplion dapplion dapplion approved these changes

@3alpha 3alpha 3alpha approved these changes

@eduadiez eduadiez Awaiting requested review from eduadiez

@tropicar tropicar Awaiting requested review from tropicar

Assignees

@pablomendezroyo pablomendezroyo

Labels
installer This issue is related to the installer
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Uninstall dappnode and Exit if dappnode_install.sh fails
3 participants
@pablomendezroyo @dapplion @3alpha