Skip to content

Commit

Permalink
Fix ice-lite attribute
Browse files Browse the repository at this point in the history
Fixes pion#2195
  • Loading branch information
enobufs authored and daonb committed Nov 20, 2022
1 parent 150d26d commit 814eebf
Show file tree
Hide file tree
Showing 2 changed files with 21 additions and 1 deletion.
2 changes: 1 addition & 1 deletion sdp.go
Original file line number Diff line number Diff line change
Expand Up @@ -538,7 +538,7 @@ func populateSDP(d *sdp.SessionDescription, isPlanB bool, dtlsFingerprints []DTL

if isICELite {
// RFC 5245 S15.3
d = d.WithValueAttribute(sdp.AttrKeyICELite, sdp.AttrKeyICELite)
d = d.WithValueAttribute(sdp.AttrKeyICELite, "")
}

return d.WithValueAttribute(sdp.AttrKeyGroup, bundleValue), nil
Expand Down
20 changes: 20 additions & 0 deletions sdp_test.go
Original file line number Diff line number Diff line change
Expand Up @@ -449,6 +449,26 @@ func TestPopulateSDP(t *testing.T) {
}
assert.Equal(t, true, foundVP8, "vp8 should be present in sdp")
})
t.Run("ice-lite", func(t *testing.T) {
se := SettingEngine{}
se.SetLite(true)

offerSdp, err := populateSDP(&sdp.SessionDescription{}, false, []DTLSFingerprint{}, se.sdpMediaLevelFingerprints, se.candidates.ICELite, &MediaEngine{}, connectionRoleFromDtlsRole(defaultDtlsRoleOffer), []ICECandidate{}, ICEParameters{}, []mediaSection{}, ICEGatheringStateComplete)
assert.Nil(t, err)

var found bool
// ice-lite is an session-level attribute
for _, a := range offerSdp.Attributes {
if a.Key == sdp.AttrKeyICELite {
// ice-lite does not have value (e.g. ":<value>") and it should be an empty string
if a.Value == "" {
found = true
break
}
}
}
assert.Equal(t, true, found, "ICELite key should be present")
})
}

func TestGetRIDs(t *testing.T) {
Expand Down

0 comments on commit 814eebf

Please sign in to comment.