Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This pull requests add support for Swift v4 in
FX
. Please note, my main goal was to get this working again - not to provide a fully overhauled API. That said, folks can at least useFX
again in their projects and we got a new common ground to build upon.This pull requests depends on danthorpe/Money#92 - which adds arithmetic support for
ISOMoney
when used together withDecimal
.I've added a new protocol
ISOMoneyProtocol
which to allows aFXProvider
to work with all available currencies (ISOMoneyProtocol
bridges the needed values fromISOMoney<C: ISOCurrencyProtocol>
in a generic way). You may or may not want to moveISOMoneyProtocol
to theMoney
framework instead ofFX
.The dependency upon
ValueCoding
is completely removed as it's obsolete. However, I did not implement theCodeable
protocol. Shouldn't be too hard to add it if anyone needs it.The Yahoo Provider is completely removed too, since the service is no longer available. For details see: https://stackoverflow.com/questions/47099005/did-yahoo-finance-just-discontinue-their-csv-download