Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

sway: handle cursor names containing spaces #654

Merged
merged 1 commit into from
Dec 3, 2024
Merged

sway: handle cursor names containing spaces #654

merged 1 commit into from
Dec 3, 2024

Conversation

trueNAHO
Copy link
Collaborator

Closes: #648
Fixes: 0779524 ("Add cursor support (#172)")
Link: #654

@saygo-png, can you confirm this resolves #648.

@trueNAHO
Copy link
Collaborator Author

trueNAHO commented Nov 30, 2024 •
edited
Loading

@danth's approval is required for me to merge this PR once @saygo-png approved this PR.

@trueNAHO trueNAHO requested a review from danth November 30, 2024 19:27
@saygo-png
Copy link

I've applied this patch to stylix 24.05, and it fixed the issue.

@trueNAHO trueNAHO enabled auto-merge (squash) December 1, 2024 17:08
danth
danth approved these changes Dec 3, 2024
View reviewed changes
Copy link
Owner

@danth danth left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This is a good improvement. Note that it may still fail if the cursor name contains a ", but I think that is highly unlikely.

@trueNAHO trueNAHO merged commit 111c75d into danth:master Dec 3, 2024
12 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@danth danth danth approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Sway wrong string quoting for xcursor
3 participants
@trueNAHO @saygo-png @danth