-
-
Notifications
You must be signed in to change notification settings - Fork 158
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
neovim: fix SignColumn transparency #628
base: master
Are you sure you want to change the base?
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I verified that this PR builds in all cases:
Tested-by: NAHO <[email protected]>
However, since my setup causes weird colors (regardless of this PR) when enabling these options, I am unsure how valuable my testing is.
@anotherhadi, can you verify and approve whether this PR closes your issue #599?
It does not, however I didn't enabled cursorline.
|
I did not change anything involving LineNr currently, so that makes sense. Is SignColumn itself transparent though? |
No Here are my related settings: programs.stylix = {
targets.nixvim.transparentBackground = {
main = true;
signColumn = true;
};
targets.nixvim.plugin = "base16-nvim";
};
programs.nixvim.opts = {
signcolumn = "yes";
cursorline = false;
number = true;
relativenumber = true;
}; |
Closes #599 .
This does not fully resolve the issue with SignColumn being not transparent, as that behavior is dependent on the option
cursorline
, as they change the highlight groups used for the sign column. In addition,LineNr
is also not transparent and is dependent on bothcursorline
andrelativenumber
. I think these issues are to be best resolved later on by #249 by relying on the respective vim highlight groups.Regardless, this change does fix SignColumn when neither of those options are set.