Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

stylix: set GTK icon theme #603

Open
wants to merge 40 commits into
base: master
Choose a base branch
from
Open

stylix: set GTK icon theme #603

wants to merge 40 commits into from

Conversation

laycookie
Copy link

@laycookie laycookie commented Nov 5, 2024

Closes: #458

Copy link
Collaborator

@trueNAHO trueNAHO left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Is this PR ready for review? I will mark this PR as draft for organizational reasons. Feel free to mark this PR as ready when it is.

Make sure to address the GitHub warnings when looking at https://github.com/danth/stylix/pull/603/files.

stylix/hm/icon.nix Outdated Show resolved Hide resolved
@trueNAHO trueNAHO marked this pull request as draft November 7, 2024 15:33
@laycookie laycookie marked this pull request as ready for review November 7, 2024 21:13
@laycookie
Copy link
Author

laycookie commented Nov 7, 2024

I resolved all the linting warnings, however I was unable to test this build because I broke my nix distro. (long story) It should still work but if anyone could test my branch that would be ideal.
Note: If you enable iconTheme, and set a package option, but not set light or dark which correspond to the names of the iconTheme for there appropriate polarity, the config will fail to build. This is intended behavior which was inherited directly from gtk.

If you just set name for one polarity, it will build and use that polarity icon theme for both polarities.

stylix/hm/icon.nix Show resolved Hide resolved
stylix/hm/icon.nix Outdated Show resolved Hide resolved
@trueNAHO trueNAHO requested review from danth and removed request for trueNAHO November 27, 2024 08:20
@trueNAHO trueNAHO changed the title Stylix Implimentation of #458 stylix: set GTK icon theme Nov 27, 2024
Copy link
Collaborator

@trueNAHO trueNAHO left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Reviewed-by: NAHO <[email protected]>

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

is it possible to set iconTheme in stylix?
2 participants