Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

stylix: bump tinted-kitty input #588

Merged
merged 1 commit into from
Oct 9, 2024

Conversation

trueNAHO
Copy link
Collaborator

@trueNAHO trueNAHO commented Oct 7, 2024

Closes: #567
Link: #588

trueNAHO added a commit to trueNAHO/stylix that referenced this pull request Oct 7, 2024
@trueNAHO trueNAHO force-pushed the stylix-bump-tinted-kitty-input branch from d7b3792 to b4b51b7 Compare October 7, 2024 14:07
@trueNAHO trueNAHO marked this pull request as ready for review October 7, 2024 14:07
@trueNAHO
Copy link
Collaborator Author

trueNAHO commented Oct 7, 2024

Cc: @psynyde

@trueNAHO
Copy link
Collaborator Author

trueNAHO commented Oct 8, 2024

@psynyde, can you confirm whether this PR resolves #567.

@psynyde
Copy link

psynyde commented Oct 8, 2024

@psynyde, can you confirm whether this PR resolves #567.

Yes, this should solve the issue.

@trueNAHO trueNAHO enabled auto-merge (squash) October 8, 2024 10:58
@trueNAHO trueNAHO requested a review from danth October 8, 2024 10:58
Copy link
Owner

@danth danth left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@trueNAHO trueNAHO merged commit 5699ba9 into danth:master Oct 9, 2024
10 checks passed
trueNAHO added a commit to trueNAHO/stylix that referenced this pull request Oct 9, 2024
Downgrade and lock the tinted-kitty input to avoid upstream breaking
changes.

Considering that Stylix eventually re-implements tinted-kitty's
functionality [1], it might be easiest to lock this input to avoid
wasted maintenance effort.

This downgrade revokes commit 5699ba9 ("stylix: bump tinted-kitty
input (danth#588)"), which resolved the issue "bug: inconsistent color
between terminals (foot & kitty)" [2] by pulling [3]. Since the desired
commit [3] follows the commit introducing the breaking changes [4], it
cannot be pulled without resolving these breaking changes.

[1]: danth#534
[2]: danth#567
[3]: tinted-theming/tinted-kitty@292c717
[4]: tinted-theming/tinted-kitty@9569d8a

Link: danth#571
Link: danth#589
trueNAHO added a commit that referenced this pull request Oct 11, 2024
Downgrade and lock the tinted-kitty input to avoid upstream breaking
changes.

Considering that Stylix eventually re-implements tinted-kitty's
functionality [1], it might be easiest to lock this input to avoid
wasted maintenance effort.

This downgrade revokes commit 5699ba9 ("stylix: bump tinted-kitty
input (#588)"), which resolved the issue "bug: inconsistent color
between terminals (foot & kitty)" [2] by pulling [3]. Since the desired
commit [3] follows the commit introducing the breaking changes [4], it
cannot be pulled without resolving these breaking changes.

[1]: #534
[2]: #567
[3]: tinted-theming/tinted-kitty@292c717
[4]: tinted-theming/tinted-kitty@9569d8a

Link: #571
Link: #589
Mikilio pushed a commit to Mikilio/stylix that referenced this pull request Nov 4, 2024
Mikilio pushed a commit to Mikilio/stylix that referenced this pull request Nov 4, 2024
Downgrade and lock the tinted-kitty input to avoid upstream breaking
changes.

Considering that Stylix eventually re-implements tinted-kitty's
functionality [1], it might be easiest to lock this input to avoid
wasted maintenance effort.

This downgrade revokes commit 5699ba9 ("stylix: bump tinted-kitty
input (danth#588)"), which resolved the issue "bug: inconsistent color
between terminals (foot & kitty)" [2] by pulling [3]. Since the desired
commit [3] follows the commit introducing the breaking changes [4], it
cannot be pulled without resolving these breaking changes.

[1]: danth#534
[2]: danth#567
[3]: tinted-theming/tinted-kitty@292c717
[4]: tinted-theming/tinted-kitty@9569d8a

Link: danth#571
Link: danth#589
mateusauler pushed a commit to mateusauler/stylix that referenced this pull request Nov 17, 2024
mateusauler pushed a commit to mateusauler/stylix that referenced this pull request Nov 17, 2024
Downgrade and lock the tinted-kitty input to avoid upstream breaking
changes.

Considering that Stylix eventually re-implements tinted-kitty's
functionality [1], it might be easiest to lock this input to avoid
wasted maintenance effort.

This downgrade revokes commit 5699ba9 ("stylix: bump tinted-kitty
input (danth#588)"), which resolved the issue "bug: inconsistent color
between terminals (foot & kitty)" [2] by pulling [3]. Since the desired
commit [3] follows the commit introducing the breaking changes [4], it
cannot be pulled without resolving these breaking changes.

[1]: danth#534
[2]: danth#567
[3]: tinted-theming/tinted-kitty@292c717
[4]: tinted-theming/tinted-kitty@9569d8a

Link: danth#571
Link: danth#589
mateusauler pushed a commit to mateusauler/stylix that referenced this pull request Nov 20, 2024
mateusauler pushed a commit to mateusauler/stylix that referenced this pull request Nov 20, 2024
Downgrade and lock the tinted-kitty input to avoid upstream breaking
changes.

Considering that Stylix eventually re-implements tinted-kitty's
functionality [1], it might be easiest to lock this input to avoid
wasted maintenance effort.

This downgrade revokes commit 5699ba9 ("stylix: bump tinted-kitty
input (danth#588)"), which resolved the issue "bug: inconsistent color
between terminals (foot & kitty)" [2] by pulling [3]. Since the desired
commit [3] follows the commit introducing the breaking changes [4], it
cannot be pulled without resolving these breaking changes.

[1]: danth#534
[2]: danth#567
[3]: tinted-theming/tinted-kitty@292c717
[4]: tinted-theming/tinted-kitty@9569d8a

Link: danth#571
Link: danth#589
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

bug: inconsistent color between terminals (foot & kitty)
3 participants