-
-
Notifications
You must be signed in to change notification settings - Fork 161
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
stylix: bump tinted-kitty input #588
Merged
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
trueNAHO
force-pushed
the
stylix-bump-tinted-kitty-input
branch
from
October 7, 2024 14:07
d7b3792
to
b4b51b7
Compare
trueNAHO
force-pushed
the
stylix-bump-tinted-kitty-input
branch
from
October 7, 2024 14:08
b4b51b7
to
2426852
Compare
Cc: @psynyde |
danth
approved these changes
Oct 9, 2024
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
trueNAHO
added a commit
to trueNAHO/stylix
that referenced
this pull request
Oct 9, 2024
Downgrade and lock the tinted-kitty input to avoid upstream breaking changes. Considering that Stylix eventually re-implements tinted-kitty's functionality [1], it might be easiest to lock this input to avoid wasted maintenance effort. This downgrade revokes commit 5699ba9 ("stylix: bump tinted-kitty input (danth#588)"), which resolved the issue "bug: inconsistent color between terminals (foot & kitty)" [2] by pulling [3]. Since the desired commit [3] follows the commit introducing the breaking changes [4], it cannot be pulled without resolving these breaking changes. [1]: danth#534 [2]: danth#567 [3]: tinted-theming/tinted-kitty@292c717 [4]: tinted-theming/tinted-kitty@9569d8a Link: danth#571 Link: danth#589
trueNAHO
added a commit
that referenced
this pull request
Oct 11, 2024
Downgrade and lock the tinted-kitty input to avoid upstream breaking changes. Considering that Stylix eventually re-implements tinted-kitty's functionality [1], it might be easiest to lock this input to avoid wasted maintenance effort. This downgrade revokes commit 5699ba9 ("stylix: bump tinted-kitty input (#588)"), which resolved the issue "bug: inconsistent color between terminals (foot & kitty)" [2] by pulling [3]. Since the desired commit [3] follows the commit introducing the breaking changes [4], it cannot be pulled without resolving these breaking changes. [1]: #534 [2]: #567 [3]: tinted-theming/tinted-kitty@292c717 [4]: tinted-theming/tinted-kitty@9569d8a Link: #571 Link: #589
Mikilio
pushed a commit
to Mikilio/stylix
that referenced
this pull request
Nov 4, 2024
Mikilio
pushed a commit
to Mikilio/stylix
that referenced
this pull request
Nov 4, 2024
Downgrade and lock the tinted-kitty input to avoid upstream breaking changes. Considering that Stylix eventually re-implements tinted-kitty's functionality [1], it might be easiest to lock this input to avoid wasted maintenance effort. This downgrade revokes commit 5699ba9 ("stylix: bump tinted-kitty input (danth#588)"), which resolved the issue "bug: inconsistent color between terminals (foot & kitty)" [2] by pulling [3]. Since the desired commit [3] follows the commit introducing the breaking changes [4], it cannot be pulled without resolving these breaking changes. [1]: danth#534 [2]: danth#567 [3]: tinted-theming/tinted-kitty@292c717 [4]: tinted-theming/tinted-kitty@9569d8a Link: danth#571 Link: danth#589
mateusauler
pushed a commit
to mateusauler/stylix
that referenced
this pull request
Nov 17, 2024
mateusauler
pushed a commit
to mateusauler/stylix
that referenced
this pull request
Nov 17, 2024
Downgrade and lock the tinted-kitty input to avoid upstream breaking changes. Considering that Stylix eventually re-implements tinted-kitty's functionality [1], it might be easiest to lock this input to avoid wasted maintenance effort. This downgrade revokes commit 5699ba9 ("stylix: bump tinted-kitty input (danth#588)"), which resolved the issue "bug: inconsistent color between terminals (foot & kitty)" [2] by pulling [3]. Since the desired commit [3] follows the commit introducing the breaking changes [4], it cannot be pulled without resolving these breaking changes. [1]: danth#534 [2]: danth#567 [3]: tinted-theming/tinted-kitty@292c717 [4]: tinted-theming/tinted-kitty@9569d8a Link: danth#571 Link: danth#589
mateusauler
pushed a commit
to mateusauler/stylix
that referenced
this pull request
Nov 20, 2024
mateusauler
pushed a commit
to mateusauler/stylix
that referenced
this pull request
Nov 20, 2024
Downgrade and lock the tinted-kitty input to avoid upstream breaking changes. Considering that Stylix eventually re-implements tinted-kitty's functionality [1], it might be easiest to lock this input to avoid wasted maintenance effort. This downgrade revokes commit 5699ba9 ("stylix: bump tinted-kitty input (danth#588)"), which resolved the issue "bug: inconsistent color between terminals (foot & kitty)" [2] by pulling [3]. Since the desired commit [3] follows the commit introducing the breaking changes [4], it cannot be pulled without resolving these breaking changes. [1]: danth#534 [2]: danth#567 [3]: tinted-theming/tinted-kitty@292c717 [4]: tinted-theming/tinted-kitty@9569d8a Link: danth#571 Link: danth#589
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Closes: #567
Link: #588