wezterm: support fancy_tab_bar #564
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
I agree with removing Changes look good to me, but I haven't tested yet. |
trueNAHO
approved these changes
Sep 23, 2024
There was a problem hiding this comment.
I didn't test this, but LGTM.
Approved-by: NAHO <[email protected]>
trueNAHO
changed the title
mateusauler
pushed a commit
to mateusauler/stylix
that referenced
this pull request
Nov 17, 2024
By default, the fancy tabbar doesn't respect colorschemes, see wez/wezterm#2615. But I've found that if you set the tabbar colors in the config.lua in addition to the colors/stylix.toml file, the fancy tabbar does respect the colors set. This change doesn't affect the retro tab theming, which I made sure to test.
mateusauler
pushed a commit
to mateusauler/stylix
that referenced
this pull request
Nov 20, 2024
By default, the fancy tabbar doesn't respect colorschemes, see wez/wezterm#2615. But I've found that if you set the tabbar colors in the config.lua in addition to the colors/stylix.toml file, the fancy tabbar does respect the colors set. This change doesn't affect the retro tab theming, which I made sure to test.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
By default, the fancy tabbar doesn't respect colorschemes, see wez/wezterm#2615. But I've found that if you set the tabbar colors in the config.lua in addition to the colors/stylix.toml file, the fancy tabbar does respect the colors set.
Here's what it ends up looking like:
This change doesn't affect the retro tab theming, which I made sure to test.
My only doubt is whether I should have kept the
use_fancy_tab_bar = false,line. Keeping this line will keep everyone's current wezterm config unchanged, but will differ from wezterm's default look. Removing the line will make it so everyone who uses stylix and doesn't haveuse_fancy_tab_bar = false,in their config will now have the fancy tabbar all of a sudden, but it is in line with the default wezterm look. I ended up removing it, but I can add it back, if needed.