-
-
Notifications
You must be signed in to change notification settings - Fork 158
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
stylix: adding option for other wallpapers and improvements (DRAFT) #508
base: master
Are you sure you want to change the base?
Conversation
Based on the patch, I am unsure what the purpose or functionality of this PR is. Could you clarify how it is trying to solve what problem? |
Actually, I am unfamiliar with the exact extent of the |
The It is currently only used in a single place within Stylix, in the GRUB module. (We could consider deprecating the |
We should consider better renaming the What should we do about this PR then?
It might be better to keep the |
Still, I think it would be a nice addition :) |
I have adapted the function to generate a wallpaper with the Nix(OS) logo, taken from misterio77/nix-colors.
The code still needs some fixes, but the general idea should be there.
I thought of adding an additional file (
nix-wallpaper.nix
), which will be imported instead of the previouspixel.nix
. This file will contain all the function calls that generate wallpapers based on a scheme, such aspixel-wallpaper
andflake-wallpaper
.As I said, it still needs some fixes, and I haven’t changed the content of
pixel-wallpaper.nix
because it's not clear to me how to adapt it; in my humble opinion, we could follow the structure offlake-wallpaper
.