-
-
Notifications
You must be signed in to change notification settings - Fork 159
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
mc: init #463
base: master
Are you sure you want to change the base?
mc: init #463
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Should we remove the non-color related declarations:
Stylix should aim to declare only necessary options. For example, #174 removed unnecessary Stylix declarations.
|
||
[Lines] | ||
horiz = ─ | ||
vert = │ | ||
lefttop = ┌ | ||
righttop = ┐ | ||
leftbottom = └ | ||
rightbottom = ┘ | ||
topmiddle = ┬ | ||
bottommiddle = ┴ | ||
leftmiddle = ├ | ||
rightmiddle = ┤ | ||
cross = ┼ | ||
dhoriz = ─ | ||
dvert = │ | ||
dlefttop = ┌ | ||
drighttop = ┐ | ||
dleftbottom = └ | ||
drightbottom = ┘ | ||
dtopmiddle = ┬ | ||
dbottommiddle = ┴ | ||
dleftmiddle = ├ | ||
drightmiddle = ┤ |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Stylix should aim to declare only necessary options. For example, #174 removed unnecessary Stylix declarations.
[Lines] | |
horiz = ─ | |
vert = │ | |
lefttop = ┌ | |
righttop = ┐ | |
leftbottom = └ | |
rightbottom = ┘ | |
topmiddle = ┬ | |
bottommiddle = ┴ | |
leftmiddle = ├ | |
rightmiddle = ┤ | |
cross = ┼ | |
dhoriz = ─ | |
dvert = │ | |
dlefttop = ┌ | |
drighttop = ┐ | |
dleftbottom = └ | |
drightbottom = ┘ | |
dtopmiddle = ┬ | |
dbottommiddle = ┴ | |
dleftmiddle = ├ | |
drightmiddle = ┤ |
|
||
[widget-common] | ||
sort-sign-up = ↑ | ||
sort-sign-down = ↓ | ||
|
||
[widget-panel] | ||
hiddenfiles-sign-show = • | ||
hiddenfiles-sign-hide = ○ | ||
history-prev-item-sign = « | ||
history-next-item-sign = » | ||
history-show-list-sign = ^ | ||
filename-scroll-left-char = « | ||
filename-scroll-right-char = » | ||
|
||
[widget-editor] | ||
window-state-char = ↕ | ||
window-close-char = ✕ |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Stylix should aim to declare only necessary options. For example, #174 removed unnecessary Stylix declarations.
[widget-common] | |
sort-sign-up = ↑ | |
sort-sign-down = ↓ | |
[widget-panel] | |
hiddenfiles-sign-show = • | |
hiddenfiles-sign-hide = ○ | |
history-prev-item-sign = « | |
history-next-item-sign = » | |
history-show-list-sign = ^ | |
filename-scroll-left-char = « | |
filename-scroll-right-char = » | |
[widget-editor] | |
window-state-char = ↕ | |
window-close-char = ✕ |
@@ -0,0 +1,160 @@ | |||
{ config, lib, pkgs, ... }: | |||
|
|||
with lib; |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Consider removing with lib;
: #425.
Co-authored-by: NAHO <[email protected]>
To: @i-am-logger Are the non-colored related declarations required:
If not, feel free to resolve the pending requested chages. |
yes, they are required, otherwise mc spit a config error |
This resolves the following pending change requests, right: In that case, the following change request is the only blocker: |
Closes: #121