Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

mc: init #463

Open
wants to merge 5 commits into
base: master
Choose a base branch
from
Open

mc: init #463

wants to merge 5 commits into from

Conversation

i-am-logger
Copy link
Contributor

@i-am-logger i-am-logger commented Jul 9, 2024

Closes: #121

@trueNAHO trueNAHO changed the title added: mc (midnight commander) mc: init Jul 9, 2024
Copy link
Collaborator

@trueNAHO trueNAHO left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Should we remove the non-color related declarations:

Stylix should aim to declare only necessary options. For example, #174 removed unnecessary Stylix declarations.

-- #388 (comment)

Comment on lines +20 to +42

[Lines]
horiz = ─
vert = │
lefttop = ┌
righttop = ┐
leftbottom = └
rightbottom = ┘
topmiddle = ┬
bottommiddle = ┴
leftmiddle = ├
rightmiddle = ┤
cross = ┼
dhoriz = ─
dvert = │
dlefttop = ┌
drighttop = ┐
dleftbottom = └
drightbottom = ┘
dtopmiddle = ┬
dbottommiddle = ┴
dleftmiddle = ├
drightmiddle = ┤
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Stylix should aim to declare only necessary options. For example, #174 removed unnecessary Stylix declarations.

-- #388 (comment)

Suggested change
[Lines]
horiz =
vert =
lefttop =
righttop =
leftbottom =
rightbottom =
topmiddle =
bottommiddle =
leftmiddle =
rightmiddle =
cross =
dhoriz =
dvert =
dlefttop =
drighttop =
dleftbottom =
drightbottom =
dtopmiddle =
dbottommiddle =
dleftmiddle =
drightmiddle =

modules/mc/hm.nix Outdated Show resolved Hide resolved
Comment on lines +142 to +158

[widget-common]
sort-sign-up = ↑
sort-sign-down = ↓

[widget-panel]
hiddenfiles-sign-show = •
hiddenfiles-sign-hide = ○
history-prev-item-sign = «
history-next-item-sign = »
history-show-list-sign = ^
filename-scroll-left-char = «
filename-scroll-right-char = »

[widget-editor]
window-state-char = ↕
window-close-char = ✕
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Stylix should aim to declare only necessary options. For example, #174 removed unnecessary Stylix declarations.

-- #388 (comment)

Suggested change
[widget-common]
sort-sign-up =
sort-sign-down =
[widget-panel]
hiddenfiles-sign-show =
hiddenfiles-sign-hide =
history-prev-item-sign = «
history-next-item-sign = »
history-show-list-sign = ^
filename-scroll-left-char = «
filename-scroll-right-char = »
[widget-editor]
window-state-char =
window-close-char =

modules/mc/hm.nix Outdated Show resolved Hide resolved
@@ -0,0 +1,160 @@
{ config, lib, pkgs, ... }:

with lib;
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Consider removing with lib;: #425.

@trueNAHO
Copy link
Collaborator

To: @i-am-logger

Are the non-colored related declarations required:

Should we remove the non-color related declarations:

Stylix should aim to declare only necessary options. For example, #174 removed unnecessary Stylix declarations.
-- #388 (comment)

If not, feel free to resolve the pending requested chages.

@i-am-logger
Copy link
Contributor Author

To: @i-am-logger

Are the non-colored related declarations required:

Should we remove the non-color related declarations:

Stylix should aim to declare only necessary options. For example, #174 removed unnecessary Stylix declarations.
-- #388 (comment)

If not, feel free to resolve the pending requested chages.

yes, they are required, otherwise mc spit a config error

@trueNAHO
Copy link
Collaborator

trueNAHO commented Nov 30, 2024

Are the non-colored related declarations required:

[...]

If not, feel free to resolve the pending requested chages.

yes, they are required, otherwise mc spit a config error

This resolves the following pending change requests, right:

In that case, the following change request is the only blocker:

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

midnight commander: add support
2 participants