Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

perf(flake): remove runtime fetch operations #224

Merged

Conversation

trueNAHO
Copy link
Collaborator

Closes: #222

Additionally, I took the luxury to sort the inputs in flake.nix.

Copy link
Contributor

@jalil-salame jalil-salame left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

flake.nix Outdated Show resolved Hide resolved
modules/gnome/theme.nix Outdated Show resolved Hide resolved
@danth danth added the performance Improvements to or issues about performance label Jan 23, 2024
Lock 'gnome-shell' input to prevent the following build errors:

```
@nix { "action": "setPhase", "phase": "unpackPhase" }
Running phase: unpackPhase
unpacking source archive /nix/store/w0rq3maqai0z4p1zi7jvi9hbjpq7hmbx-source
source root is source
@nix { "action": "setPhase", "phase": "patchPhase" }
Running phase: patchPhase
applying patch /nix/store/4rwhawrj2r906l3xjb2fmldkqp1isx6a-shell_colors.patch
patching file data/gnome-shell-theme.gresource.xml
Hunk danth#1 succeeded at 11 with fuzz 1.
patching file data/theme/gnome-shell-sass/_common.scss
Hunk danth#1 succeeded at 230 with fuzz 2 (offset 62 lines).
patching file data/theme/gnome-shell-sass/_drawing.scss
Hunk danth#1 FAILED at 143.
1 out of 1 hunk FAILED -- saving rejects to file data/theme/gnome-shell-sass/_drawing.scss.rej
patching file data/theme/gnome-shell-sass/widgets/_calendar.scss
Hunk danth#2 succeeded at 229 (offset 7 lines).
patching file data/theme/gnome-shell-sass/widgets/_panel.scss
Hunk danth#1 FAILED at 1.
1 out of 1 hunk FAILED -- saving rejects to file data/theme/gnome-shell-sass/widgets/_panel.scss.rej
patching file data/theme/gnome-shell-sass/widgets/_quick-settings.scss
Hunk danth#1 FAILED at 110.
1 out of 1 hunk FAILED -- saving rejects to file data/theme/gnome-shell-sass/widgets/_quick-settings.scss.rej
```

Related: danth#224 (comment)
Reverts: 026bc2a
@trueNAHO trueNAHO requested a review from danth January 31, 2024 19:43
flake.nix Show resolved Hide resolved
@danth danth merged commit a2d8d6b into danth:master Feb 7, 2024
5 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
performance Improvements to or issues about performance
Projects
None yet
Development

Successfully merging this pull request may close these issues.

refactor: remove runtime fetch operations
3 participants