-
-
Notifications
You must be signed in to change notification settings - Fork 161
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
perf(flake): remove runtime fetch operations #224
Merged
danth
merged 10 commits into
danth:master
from
trueNAHO:perf-flake-remove-runtime-fetch-operations
Feb 7, 2024
Merged
perf(flake): remove runtime fetch operations #224
danth
merged 10 commits into
danth:master
from
trueNAHO:perf-flake-remove-runtime-fetch-operations
Feb 7, 2024
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jalil-salame
approved these changes
Jan 19, 2024
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
danth
reviewed
Jan 20, 2024
Lock 'gnome-shell' input to prevent the following build errors: ``` @nix { "action": "setPhase", "phase": "unpackPhase" } Running phase: unpackPhase unpacking source archive /nix/store/w0rq3maqai0z4p1zi7jvi9hbjpq7hmbx-source source root is source @nix { "action": "setPhase", "phase": "patchPhase" } Running phase: patchPhase applying patch /nix/store/4rwhawrj2r906l3xjb2fmldkqp1isx6a-shell_colors.patch patching file data/gnome-shell-theme.gresource.xml Hunk danth#1 succeeded at 11 with fuzz 1. patching file data/theme/gnome-shell-sass/_common.scss Hunk danth#1 succeeded at 230 with fuzz 2 (offset 62 lines). patching file data/theme/gnome-shell-sass/_drawing.scss Hunk danth#1 FAILED at 143. 1 out of 1 hunk FAILED -- saving rejects to file data/theme/gnome-shell-sass/_drawing.scss.rej patching file data/theme/gnome-shell-sass/widgets/_calendar.scss Hunk danth#2 succeeded at 229 (offset 7 lines). patching file data/theme/gnome-shell-sass/widgets/_panel.scss Hunk danth#1 FAILED at 1. 1 out of 1 hunk FAILED -- saving rejects to file data/theme/gnome-shell-sass/widgets/_panel.scss.rej patching file data/theme/gnome-shell-sass/widgets/_quick-settings.scss Hunk danth#1 FAILED at 110. 1 out of 1 hunk FAILED -- saving rejects to file data/theme/gnome-shell-sass/widgets/_quick-settings.scss.rej ``` Related: danth#224 (comment) Reverts: 026bc2a
This was referenced Jan 31, 2024
danth
reviewed
Feb 1, 2024
danth
approved these changes
Feb 7, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Closes: #222
Additionally, I took the luxury to sort the
inputs
inflake.nix
.