feat(modules/qutebrowser): apply dark mode depending on polarity #175
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
trueNAHO
added a commit
to trueNAHO/dotfiles
that referenced
this pull request
Oct 19, 2023
danth
approved these changes
Oct 22, 2023
There was a problem hiding this comment.
Note that the polarity defaults to either, and in that case we might choose light mode when the theme is actually dark. #102 contains a fix which this module will need to be updated to use once that gets merged. For now the current behaviour is fine because at least we get dark mode if specifically requested.
trueNAHO
added a commit
to trueNAHO/dotfiles
that referenced
this pull request
Oct 29, 2023
willemml
pushed a commit
to willemml/stylix
that referenced
this pull request
Nov 24, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Apply dark mode depending on
config.stylix.polarity.For reference, this was successfully tested with
config.stylix.polarity = "dark";andconfig.stylix.polarity = "light";.Closes: #173