Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[BUG] SignColumn not transparent #599

Open
anotherhadi opened this issue Oct 22, 2024 · 7 comments · May be fixed by #628
Open

[BUG] SignColumn not transparent #599

anotherhadi opened this issue Oct 22, 2024 · 7 comments · May be fixed by #628

Comments

@anotherhadi
Copy link

The sign column is no longer transparent after update.
Even with stylix.targets.nixvim.transparentBackground.signColumn = true

My full configuration can be found at https://github.com/anotherhadi/nixy, related files are /themes/stylix/nixy.nix and /home/programs/nvim

@anotherhadi
Copy link
Author

Maybe related to #536

@trueNAHO
Copy link
Collaborator

trueNAHO commented Oct 23, 2024

The sign column is no longer transparent after update. Even with stylix.targets.nixvim.transparentBackground.signColumn = true

[...]

Maybe related to #536

The default colorscheme plugin changed from base16-nvim to mini.base16:

Add the stylix.targets.nixvim.plugin option to select between the
previous base16-nvim and the new default mini.base16 [...] plugin,
offering better plugin integration.

-- 17f6d6e

I am pretty sure that the sign column not being transparent is an intentional feature of mini.base16.

Consider adding a new stylix.targets.nixvim.plugin variant, patching base16-nvim or mini.base16 upstream, or waiting for Stylix to implement the Vim highlight groups:

Considering that the roadmap eventually causes Stylix to implement all templates without relying on external dependencies, it might be easiest to lock the current dependency versions to avoid wasted maintenance effort.

-- #567 (comment)

@anotherhadi
Copy link
Author

Even with stylix.targets.nixvim.plugin = "base16-nvim"; I still have the same issue. Shouldn't this revert any changes made upstream?

@trueNAHO
Copy link
Collaborator

Cc: @soulsoiledit

@soulsoiledit
Copy link
Contributor

For the mini.base16 issue, it can be fixed by adding highlightOverride to each option. It seems like it's working with base16-nvim to me. The LineNr (number column) is not transparent however, which is a bit jarring though and might be what you're referring to? I don't think this was properly supported in the past either. Perhaps LineNr should be set as well?

@anotherhadi
Copy link
Author

For the mini.base16 issue, it can be fixed by adding highlightOverride to each option. It seems like it's working with base16-nvim to me. The LineNr (number column) is not transparent however, which is a bit jarring though and might be what you're referring to? I don't think this was properly supported in the past either. Perhaps LineNr should be set as well?

In my setup, neither the LineNr column nor the Sign column are transparent. How do you define highlightOverride to each option?

@soulsoiledit
Copy link
Contributor

soulsoiledit commented Oct 27, 2024

To clarify, highlightOverride would be used upstream. You can take a look here to see how to do it locally.

Also check if relativenumber or cursorline are enabled. They change the highlight groups used for the number column and sign column respectively.

soulsoiledit added a commit to soulsoiledit/stylix that referenced this issue Nov 15, 2024
soulsoiledit added a commit to soulsoiledit/stylix that referenced this issue Nov 15, 2024
soulsoiledit added a commit to soulsoiledit/stylix that referenced this issue Nov 15, 2024
soulsoiledit added a commit to soulsoiledit/stylix that referenced this issue Nov 15, 2024
soulsoiledit added a commit to soulsoiledit/stylix that referenced this issue Nov 15, 2024
soulsoiledit added a commit to soulsoiledit/stylix that referenced this issue Nov 15, 2024
@soulsoiledit soulsoiledit linked a pull request Nov 15, 2024 that will close this issue
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging a pull request may close this issue.

3 participants