Ddfbra 130 pre fetching og loading states #35
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
spaceo
reviewed
Nov 8, 2024
Comment on lines
+74
to
+78
| className={cn( | ||
| `absolute inset-0 h-auto w-full overflow-hidden rounded-sm object-contain shadow-cover-picture | ||
| transition-all duration-500 will-change-transform`, | ||
| imageLoaded ? "opacity-100" : "opacity-0" | ||
| )} |
There was a problem hiding this comment.
Suggested change
| className={cn( | |
| `absolute inset-0 h-auto w-full overflow-hidden rounded-sm object-contain shadow-cover-picture | |
| transition-all duration-500 will-change-transform`, | |
| imageLoaded ? "opacity-100" : "opacity-0" | |
| )} | |
| className={cn( | |
| `shadow-cover-picture absolute inset-0 h-auto w-full overflow-hidden rounded-sm object-contain | |
| transition-all duration-500 will-change-transform`, | |
| { | |
| "opacity-0": !imageLoaded, | |
| "opacity-100": imageLoaded, | |
| } | |
| )} |
There was a problem hiding this comment.
I like this way of treating conditionals in clsx
spaceo
reviewed
Nov 8, 2024
Comment on lines
62
to
67
| className={cn( | ||
| "mx-[-10px] mt-[-10px] flex gap-1 px-[10px] pt-[10px] text-typo-caption", | ||
| !isLast && "flex-col", | ||
| isLast && "flex-row flex-wrap content-start", | ||
| !isExpanded && "h-[102px] overflow-hidden" | ||
| )} |
There was a problem hiding this comment.
Suggested change
| className={cn( | |
| "mx-[-10px] mt-[-10px] flex gap-1 px-[10px] pt-[10px] text-typo-caption", | |
| !isLast && "flex-col", | |
| isLast && "flex-row flex-wrap content-start", | |
| !isExpanded && "h-[102px] overflow-hidden" | |
| )} | |
| className={cn( | |
| "mx-[-10px] mt-[-10px] flex gap-1 px-[10px] pt-[10px] text-typo-caption", | |
| { | |
| "flex-row flex-wrap content-start": isLast, | |
| "flex-col": !isLast, | |
| "h-[102px] overflow-hidden": !isExpanded, | |
| } | |
| )} |
There was a problem hiding this comment.
You get my point :) Consider, if you agree, using that pattern for conditionals in clsx
spaceo
approved these changes
Nov 8, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Link to issue
https://reload.atlassian.net/browse/DDFBRA-130
https://reload.atlassian.net/browse/DDFBRA-167
Description
Ghost loading and polish on search result page