DDFNEXT-220: Upgrade Storybook and Prettier [BROKEN] #759
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
JacobArrow
force-pushed
the
DDFNEXT-220-upgrade-storybook
branch
from
39ee751
to
d176915
Compare
JacobArrow
commented
Nov 4, 2024
| "eslint-plugin-react": "^7.37.2", | ||
| "eslint-plugin-react-hooks": "^4.6.2", | ||
| "eslint-webpack-plugin": "^4.2.0", | ||
| "flatpickr": "^4.6.13", | ||
| "json": "^11.0.0", | ||
| "markdownlint-cli2": "^0.4.0", | ||
| "postcss": "^8.4.47", | ||
| "prettier": "^2.7.1", | ||
| "prettier": "^3.3.3", |
There was a problem hiding this comment.
We need to upgrade Prettier to make storybook-addon-html work with Storybook 8, which is why Stylelint also has been upgraded.
JacobArrow
changed the title
JacobArrow
force-pushed
the
DDFNEXT-220-upgrade-storybook
branch
3 times, most recently
from
d176915
to
70ef6ec
Compare
JacobArrow
force-pushed
the
DDFNEXT-220-upgrade-storybook
branch
7 times, most recently
from
a6dee18
to
adf3720
Compare
As of Stylelint v15 stylelint-config-prettier is no longer needed as all style-related rules have been deprecated.
With Storybook 8.0 the build system now requires explicit configuration for CSS
These were accidentally removed in a previous commit while testing
Storybook will no longer automatically import CSS. Maybe flatpickr CSS should be imported globally at some point?
Chromatic has changed the way they handle viewports for stories. https://www.chromatic.com/docs/storybook/viewports/#migration-from-viewports-legacy-to-modes
JacobArrow
force-pushed
the
DDFNEXT-220-upgrade-storybook
branch
from
adf3720
to
9755bdb
Compare
|
This PR has moved to #766 |
JacobArrow
changed the title
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Link to issue
https://reload.atlassian.net/browse/DDFBRA-161
Description
npx storybook@latest migrate.mdxfiles withnpx storybook@latest migrateargs: {}instead ofargTypes.defaultValue: {}@whitespace/storybook-addon-htmlBeware that the newest version of Storybook introduces some new React warnings while compiling.