Layout units - horizontal and vertical. #402
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
After a discussion today, we agreed to introduce layout unit components. These units are used for centering stuff, and adding padding, and for adding spacing between individual elements. The idea is that this is done using markup wrappers, but I've also made them so they can be used by individual components using placeholders.
I added this as a seperate file 'cause of short time. Look over it and see what you think. I think this is modular enough to be used for what we have and expanded upon later with __background modifications etc. Hopefully it makes sense, sorry for no thorough explanation. Look at top comment of the file, and see example at the bottom.
|
I don't have much experience with "layout" CSS classes, so it's difficult for me to determine what works best. @LasseStaus is there a I think Lasse's naming is the best. But let's talk about it tomorrow. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
After a discussion today, we agreed to introduce layout unit components. These units are used for centering stuff, and adding padding, and for adding spacing between individual elements.
The idea is that this is done using markup wrappers, but I've also made them so they can be used by individual components using placeholders.