Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Speed up ci:reset by passing along a pre-built DB. #1629

Closed
wants to merge 2 commits into from
Closed
Show file tree
Hide file tree
Changes from 1 commit
Commits
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
34 changes: 20 additions & 14 deletions Taskfile.yml
Original file line number Diff line number Diff line change
Expand Up @@ -125,8 +125,8 @@ tasks:
cmds:
- docker compose {{ .DOCKER_COMPOSE_FILES }} pull

dev:reset:
desc: Create local development setup in a clean state
dev:reset:common:
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

What is the purpose of dev:reset:common? Would be nice to have in the description what the intention is.
Also consider which of the newly introduced dev:rest* cmds private so it is clear what is meant to be run as seprate task cmds and what is used internally

desc: Preparing the environments for resetting the setup.
deps:
# Build new containers if necessary.
- dev:build
Expand All @@ -149,22 +149,16 @@ tasks:
- task dev:pull
# Start local environment.
- task dev:start

dev:reset:
desc: Create local development setup in a clean state
cmds:
- task dev:reset:before
# Install site.
- task dev:cli -- drush site-install --existing-config -y
# Practice shows that the cache needs to be cleared to avoid configuration
# errors even after a site install.
- task dev:cache:clear:drupal
# Import translations.
- |
if [ -n "${SKIP_LANGUAGE_IMPORT}" ]; then
echo "Skipping language import due to SKIP_LANGUAGE_IMPORT environment variable"
else
task dev:cli -- drush locale-check
task dev:cli -- drush locale-update
task dev:cli -- drush dpl_po:import-remote-config-po da https://danskernesdigitalebibliotek.github.io/dpl-cms/translations/da.config.po
fi
# Clear all caches to ensure we have a pristine setup.
- task dev:cache:clear:all
# Run deploy hooks.
- task dev:cli -- drush deploy -y
# Ensure site is reachable and warm any caches
Expand All @@ -174,6 +168,16 @@ tasks:
- task dev:create-users
# Show a one-time login to the local site.
- task dev:cli -- drush user-login
# Import translations.
- |
if [ -n "${SKIP_LANGUAGE_IMPORT}" ]; then
echo "Skipping language import due to SKIP_LANGUAGE_IMPORT environment variable"
else
task dev:cli -- drush locale-check
task dev:cli -- drush locale-update
task dev:cli -- drush dpl_po:import-remote-config-po da https://danskernesdigitalebibliotek.github.io/dpl-cms/translations/da.config.po
task dev:import-profile-translations
fi

dev:openid:configure:
desc: Set openid connect settings based on .env variables. And run cron.
Expand Down Expand Up @@ -382,7 +386,9 @@ tasks:
ci:reset:
desc: Create CI setup in a clean state
cmds:
- task dev:reset
- task dev:reset:common
- task dev:cli -- drush sqlq --file=../tools/site-reset.sql.gz
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

What is contained in site-reset.sql.gz?
It would be nice if it was documented somewhere what is happening here

- task dev:cli -- drush deploy
env:
DOCKER_COMPOSE_FILES: "{{ .DOCKER_COMPOSE_FILES_CI }}"
SKIP_LANGUAGE_IMPORT: "true"
Expand Down
Binary file added tools/site-reset.sql.gz
Binary file not shown.
Loading