Add preact as react alias. #94
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This reduces the bundle.js size from 267kB -> 157kB due to the smaller DOM implementation.
|
Does fail one test which is a good indicator of what is to come. |
This is not necessary when using react and not preact. Hard to explain. Maybe the initializing speed factor of one or the other.
Codecov Report
@@ Coverage Diff @@
## master #94 +/- ##
==========================================
- Coverage 81.72% 81.41% -0.31%
==========================================
Files 47 47
Lines 651 651
Branches 155 155
==========================================
- Hits 532 530 -2
- Misses 108 110 +2
Partials 11 11
Continue to review full report at Codecov.
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
https://preactjs.com/guide/v10/differences-to-react
This reduces the
bundle.jssize from 267kB -> 157kB. ~42% decrease.On the surface we are still just writing react but the smaller size makes Preact desirable. As of this PR we are opting for using Preact for development as well to minimize compatibility issues when it comes to production but it is more than possible to only make use of Preact in production.
The main downside is the incoherencies we will encounter along the way.
But it's a big chunk to cut off and might be worth the hassle.