Update linting and formatting setup. #136
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
lasseborly
force-pushed
the
chore/separate-eslint-stylelint-prettier
branch
3 times, most recently
from
43f7689 to
410aaec
Compare
Main objective of these changes is remove some of the friction from when working on the project. Before we had eslint and prettier intertwined which made for a "secure" experience but made it so that formatting errors that were auto-fixable were being treated as errors. This would make the editing experience slow and tiresome when you would not have the appropriate editor setup that would auto-fix everything for you. These changes seperated eslint and prettier and stylelint and prettier. Letting eslint and stylelint be responsible for code quality and our own weird formatting rules whereas prettiers concerns is 100% on auto-fixable formatting. This results in no more red lines in our IDE's when it comes to prettier warnings which eases development but still maintains security of formatted code due to github actions and the proposed IDE configs supplied. Besides the seperation we also bump eslint and prettier a major version.
lasseborly
force-pushed
the
chore/separate-eslint-stylelint-prettier
branch
from
410aaec to
ecb2b28
Compare
|
This is also ready for review @kasperg |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Main objective of these changes is remove some of the friction from when
working on the project.
Before we had eslint and prettier intertwined which made for a "secure"
experience but made it so that formatting errors that were auto-fixable
were being treated as errors. This would make the editing experience
slow and tiresome when you would not have the appropriate editor setup
that would auto-fix everything for you.
These changes seperated eslint and prettier and stylelint and prettier.
Letting eslint and stylelint be responsible for code quality and our own
weird formatting rules whereas prettiers concerns is 100% on auto-fixable
formatting.
This results in no more red lines in our IDE's when it comes to prettier
warnings which eases development but still maintains security of formatted
code due to github actions and the proposed IDE configs supplied.
Besides the seperation we also bump eslint and prettier a major version.
TLDR; Provides a nicer DX