-
Notifications
You must be signed in to change notification settings - Fork 0
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[FEAT] 로그인 모달 마크업 (#18) #23
The head ref may contain hidden characters: "18-feat-\uB85C\uADF8\uC778-\uBAA8\uB2EC-\uB9C8\uD06C\uC5C5"
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
확인했습니다! LGTM
마이페이지 관련된 기능도 함께 올라온 것 같아서, pr과 관련된 파일만 push되도록 주의해주세요! pr이 밀려있어서 그런 것 같기도 하네요
src/components/layout/Header.jsx
Outdated
@@ -58,11 +68,12 @@ function Header() { | |||
</ProfileSection> | |||
) : ( | |||
<ProfileSection> | |||
<ProfileNavItem to="/login">로그인</ProfileNavItem> | |||
<ProfileNavItem onClick={handleOpenLoginModal}>로그인</ProfileNavItem> |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
모달 여는 동작 확인했습니다
확인했습니다 |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
확인했습니다!!
✨ PR 세부 내용
📝 관련 이슈
💬 리뷰 요청 사항
⏳ 기한