Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Refactored just a very few minor things. #1

Open
wants to merge 1 commit into
base: master
Choose a base branch
from
Open

Refactored just a very few minor things. #1

wants to merge 1 commit into from

Conversation

caleywoods
Copy link

I came across some stuff in The Rails 3 Way and wanted to knock out two birds with one stone (trying new ideas + pull request). I made a few minor changes and tested to the best of my ability. Feel free to take a look!

Also just wanted to share this syntax I learned for cleaning up routing where you're doing different things with a get or post (etc): https://gist.github.com/876262

@dankirkd
Copy link
Owner

Interesting, but I explicitly removed logic that would render in any format other than HTML simply so that there would be no confusion that the app supported anything but HTML.

@caleywoods
Copy link
Author

I see. Removing the :xml and :json code at the very top would again remove support for such formats. I just throw it in the index of my apps to facilitate another program or person retrieving the collection via a json or xml response.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants