#716 Increased precision of percentages in CsvSummary and TextSummary…

… reports (contributed by @tomap)
danielpalme · Dec 21, 2024 · e4757cc · e4757cc
2 parents e530e91 + 9e9bee8
commit e4757cc
Show file tree

Hide file tree

Showing 3 changed files with 7 additions and 6 deletions.
diff --git a/src/Readme.txt b/src/Readme.txt
@@ -70,6 +70,7 @@ CHANGELOG
 5.4.2.0
 
     * Fix: #700 Fixed handling of .netconfig files (sourceDirectories, reportTypes, plugins, assemblyFilters, etc.)
+    * Fix: #716 Increased precision of percentages in CsvSummary and TextSummary reports (contributed by @tomap)
     * Fix: #719 Fixed badges in MarkdownAssembliesSummary report
 
 5.4.1.0

diff --git a/src/ReportGenerator.Core/Reporting/Builders/CsvSummaryReportBuilder.cs b/src/ReportGenerator.Core/Reporting/Builders/CsvSummaryReportBuilder.cs
@@ -110,7 +110,7 @@ public void CreateSummaryReport(SummaryResult summaryResult)
                 reportTextWriter.WriteLine(
                     "{0};{1}",
                     ReportResources.Coverage2,
-                    summaryResult.CoverageQuota.HasValue ? summaryResult.CoverageQuota.Value.ToString("f1", CultureInfo.InvariantCulture) + "%" : string.Empty);
+                    summaryResult.CoverageQuota.HasValue ? summaryResult.CoverageQuota.Value.ToString(CultureInfo.InvariantCulture) + "%" : string.Empty);
                 reportTextWriter.WriteLine(
                     "{0};{1}",
                     ReportResources.CoveredLines,
@@ -134,7 +134,7 @@ public void CreateSummaryReport(SummaryResult summaryResult)
                     reportTextWriter.WriteLine(
                         "{0};{1}",
                         assembly.Name,
-                        assembly.CoverageQuota.HasValue ? assembly.CoverageQuota.Value.ToString("f1", CultureInfo.InvariantCulture) + "%" : string.Empty);
+                        assembly.CoverageQuota.HasValue ? assembly.CoverageQuota.Value.ToString(CultureInfo.InvariantCulture) + "%" : string.Empty);
 
                     if (assembly.Classes.Any())
                     {
@@ -146,7 +146,7 @@ public void CreateSummaryReport(SummaryResult summaryResult)
                         reportTextWriter.WriteLine(
                             "{0};{1}",
                             @class.Name,
-                            @class.CoverageQuota.HasValue ? @class.CoverageQuota.Value.ToString("f1", CultureInfo.InvariantCulture) + "%" : string.Empty);
+                            @class.CoverageQuota.HasValue ? @class.CoverageQuota.Value.ToString(CultureInfo.InvariantCulture) + "%" : string.Empty);
                     }
                 }
 

diff --git a/src/ReportGenerator.Core/Reporting/Builders/TextSummaryReportBuilder.cs b/src/ReportGenerator.Core/Reporting/Builders/TextSummaryReportBuilder.cs
@@ -106,7 +106,7 @@ public void CreateSummaryReport(SummaryResult summaryResult)
                 reportTextWriter.WriteLine("  {0} {1}", ReportResources.Assemblies2, assembliesWithClasses.Count().ToString(CultureInfo.InvariantCulture));
                 reportTextWriter.WriteLine("  {0} {1}", ReportResources.Classes, assembliesWithClasses.SelectMany(a => a.Classes).Count().ToString(CultureInfo.InvariantCulture));
                 reportTextWriter.WriteLine("  {0} {1}", ReportResources.Files2, assembliesWithClasses.SelectMany(a => a.Classes).SelectMany(a => a.Files).Distinct().Count().ToString(CultureInfo.InvariantCulture));
-                reportTextWriter.WriteLine("  {0} {1}", ReportResources.Coverage2, summaryResult.CoverageQuota.HasValue ? summaryResult.CoverageQuota.Value.ToString("f1", CultureInfo.InvariantCulture) + "%" : string.Empty);
+                reportTextWriter.WriteLine("  {0} {1}", ReportResources.Coverage2, summaryResult.CoverageQuota.HasValue ? summaryResult.CoverageQuota.Value.ToString(CultureInfo.InvariantCulture) + "%" : string.Empty);
                 reportTextWriter.WriteLine("  {0} {1}", ReportResources.CoveredLines, summaryResult.CoveredLines.ToString(CultureInfo.InvariantCulture));
                 reportTextWriter.WriteLine("  {0} {1}", ReportResources.UncoveredLines, (summaryResult.CoverableLines - summaryResult.CoveredLines).ToString(CultureInfo.InvariantCulture));
                 reportTextWriter.WriteLine("  {0} {1}", ReportResources.CoverableLines, summaryResult.CoverableLines.ToString(CultureInfo.InvariantCulture));
@@ -146,7 +146,7 @@ public void CreateSummaryReport(SummaryResult summaryResult)
 
                     foreach (var assembly in assembliesWithClasses)
                     {
-                        string assemblyQuota = assembly.CoverageQuota.HasValue ? assembly.CoverageQuota.Value.ToString("f1", CultureInfo.InvariantCulture) + "%" : string.Empty;
+                        string assemblyQuota = assembly.CoverageQuota.HasValue ? assembly.CoverageQuota.Value.ToString(CultureInfo.InvariantCulture) + "%" : string.Empty;
                         reportTextWriter.WriteLine();
                         reportTextWriter.WriteLine(
                             "{0}{1}  {2}",
@@ -156,7 +156,7 @@ public void CreateSummaryReport(SummaryResult summaryResult)
 
                         foreach (var @class in assembly.Classes)
                         {
-                            string classQuota = @class.CoverageQuota.HasValue ? @class.CoverageQuota.Value.ToString("f1", CultureInfo.InvariantCulture) + "%" : string.Empty;
+                            string classQuota = @class.CoverageQuota.HasValue ? @class.CoverageQuota.Value.ToString(CultureInfo.InvariantCulture) + "%" : string.Empty;
                             reportTextWriter.WriteLine(
                                 "  {0}{1}  {2}",
                                 @class.DisplayName,
-Original file line number
+Diff line change
@@ Expand Up / @@ -70,6 +70,7 @@ CHANGELOG @@
 .4.2.0
         * Fix: #700 Fixed handling of .netconfig files (sourceDirectories, reportTypes, plugins, assemblyFilters, etc.)
+        * Fix: #716 Increased precision of percentages in CsvSummary and TextSummary reports (contributed by @tomap)
         * Fix: #719 Fixed badges in MarkdownAssembliesSummary report
 .4.1.0
@@ Expand Down @@