Skip to content

Commit

Permalink
fix(Reminder): no notifications unless someone is working
Browse files Browse the repository at this point in the history
If it's not a work hour for _any_ of the suggested reviewers, don't
bother sending a notification

Fixes #14
  • Loading branch information
Daniel Ma committed May 15, 2017
1 parent 1716006 commit d3c3b0c
Showing 1 changed file with 1 addition and 1 deletion.
2 changes: 1 addition & 1 deletion lib/review_bot/reminder.rb
Original file line number Diff line number Diff line change
Expand Up @@ -74,7 +74,7 @@ def potential_notifications
pull.reviewers.include?(reviewer['github'])
end

next if suggested_reviewers.empty?
next if suggested_reviewers.select(&:work_hour?).empty?

Notification.new(
pull_request: pull,
Expand Down

0 comments on commit d3c3b0c

Please sign in to comment.