Fix potential cause of segfaults in smallfry #131
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I occasionally run into segfaults when using
jpeg-recompress -m smallfry
on some images.Explanation of the fix
This fix is required because in line 81 there is
DVAL(j + 2)
which is transformed intoabs(old[j+2] - new[j+2])
.On the last iteration in this loop
j
will be equalwidth - 2
, meaning we are accessingabs(old[width] - new[width])
,which in case of the last row of an image is beyond what was allocated.