Fix TypeError: moment is not a function(…) #1765
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Hey, I have been using https://github.com/skratchdot/react-bootstrap-daterangepicker which wraps daterangepicker, we've migrated our site to React 16.4 from React 15 and encountered an error with the base library.
"TypeError: moment is not a function"
It appears when inserted into the webpack build, the library tries to use 'moment' however it receives an object instead of moment, the object contains a 'default' property that is the actual moment method.
I've added a check when the package is built via webpack to check if moment is not a function and whether it has a default property, and if so, override moment with moment.default and continue as usual.
This change fixed the error on our project and we're using a forked version for the meantime.
Thanks in advance for this awesome library.