Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

No need to install gitlab for less than Ruby 2.5.0 #trivial #1449

Merged
merged 1 commit into from
Sep 19, 2023

Conversation

mataku
Copy link
Contributor

@mataku mataku commented Aug 1, 2023

The current required_ruby_version is specified as ">= 2.7.0", so there is no need to consider Ruby version "< 2.7.0".

It seems that the minimum Ruby version was changed to 2.5 in gitlab gem 4.14.1, so special handling was required.

…quired_ruby_version is specified as ">= 2.7.0"
@mataku mataku marked this pull request as ready for review August 1, 2023 14:47
@orta
Copy link
Member

orta commented Sep 19, 2023

Agree, thanks!

@orta orta merged commit 905e742 into danger:master Sep 19, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants