Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
Disallow adding text with only whitespaces
Fix AddMuteItemView to trim leading and trailing whitespaces from mute text
Fix SideMenuView text to autoscale and limit to 1 line
Fix GradientFollowButton to have consistent width and autoscale text limited to 1 line, Fix suggested users category titles to be localizable
Fix right-to-left localization issues
Checklist
Closes:
orFixes:
tags in the commit messages wherever applicable, or made sure those are not needed. See Submitting patchesTest report
Please provide a test report for the changes in this PR. You can use the template below, but feel free to modify it as needed.
Device: iPhone SE (3rd generation)
iOS: 18.1
Damus: 8ed2395
Setup: N/A
Steps:
Disallow adding text with only whitespaces
Muted
.+
button on top right.Add mute item
opacity decreases by 50% and is disabled (not tappable), and theX
button to clear the text box is hidden.Fix AddMuteItemView to trim leading and trailing whitespaces from mute text
Muted
.+
button on top right.leading and trailing spaces
in the text entry.Add mute item
button.leading and trailing spaces
has been added as a mute phrase but with the leading and trailing spaces trimmed.Fix SideMenuView text to autoscale and limit to 1 line
Muted
does not wrap and autoscales down to fit.Fix GradientFollowButton to have consistent width and autoscale text limited to 1 line, Fix suggested users category titles to be localizable
Always show onboarding
.Unfollow
andFollow
are consistent.Unfollow
does not wrap despite its length and autoscales down to fit.PERMACULTURE, LIVESTOCK & GARDENING
is the second category (where previously the category title wasPERMACULTURE & LIVESTOCK & GARDENING
), which means that the string is being read from theLocalizable.strings
.Fix right-to-left localization issues
Results: