LEAF BMS: Add autodetect of LEAF Generation #132
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
dalathegreat
requested review from
damienmaguire and
jsphuebner
as code owners
damienmaguire
approved these changes
Dec 5, 2024
|
Thanks Dala |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What
The LEAF has existed for many generations, and the CAN content varies depending on which gen you run on. This PR adds autodetect functionality for which generation we run on.
How
We now detect automatically between the following LEAF generations
Why
The temperature reading method currently in the code only works for ZE0. None of the other generations have the value in 0x5BC. Now that we determine generation automatically, we can on AZE0 read temperature from 0x5C0 message.
For further development, suggestion is to add active polling (0x7BB) to get values needed for 40/62kWh ZE1 batteries.